Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1405272

Summary: docker-storage-setup should not set deferred_deletion=true on RHEL
Product: Red Hat Enterprise Linux 7 Reporter: Mike Fiedler <mifiedle>
Component: dockerAssignee: Lokesh Mandvekar <lsm5>
Status: CLOSED ERRATA QA Contact: atomic-bugs <atomic-bugs>
Severity: high Docs Contact:
Priority: unspecified    
Version: 7.3CC: amurdaca, dwalsh, haowang, lsm5, lsu, mifiedle, vgoyal, wabouham
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-02 19:09:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Mike Fiedler 2016-12-16 02:20:10 UTC 
Description of problem:

docker-storage-setup adds deferred_deletion=true to /etc/sysconfig/docker-storage on RHEL when it is not supported


Version-Release number of selected component (if applicable): 1.12.4 - RHEL 7.3.1


How reproducible: always


Steps to Reproduce:
1.  run docker-storage-setup on RHEL 7.3.1 


Actual results:

/etc/sysconfig/docker-storage contains deferred_deletion=true

Expected results:

docker-storage-setup sets no unsupported options.

Additional info:
Comment 1 Mike Fiedler 2016-12-16 02:20:31 UTC 
See https://bugzilla.redhat.com/show_bug.cgi?id=1403027
Comment 2 Mike Fiedler 2016-12-16 02:34:23 UTC 
Example docker-storage after running docker-storage-setup:

DOCKER_STORAGE_OPTIONS="--storage-driver devicemapper --storage-opt dm.fs=xfs --storage-opt dm.thinpooldev=/dev/mapper/docker_vg-docker--pool --storage-opt dm.use_deferred_removal=true "


Contents of /etc/sysconfig/docker-storage-setup prior to running it:

VG=docker_vg
DEVS=/dev/xvdb
Comment 4 Daniel Walsh 2016-12-16 13:01:25 UTC 
Lokesh please make sure this is fixed in rhel7.3.2
Comment 5 Vivek Goyal 2016-12-16 13:18:16 UTC 
Upstream has this fixed. We need to build docker rpm with latest docker-storage-setup.
Comment 6 Vivek Goyal 2016-12-16 14:09:08 UTC 
Lokesh, Use this commit as top commit when you pull in docker-storage-setup.

commit 516cb9c0bc14883f46ef2362a3f5abd4d6c20b1e
Author: Vivek Goyal <vgoyal>
Date:   Tue Nov 15 09:13:45 2016 -0500

    Let lvm create metadata volume automatically


There are couple of changes after this which are fairly new and little intrusive. I want these to be tested on fedora first before pulling these into rhel.
Comment 7 Lokesh Mandvekar 2017-01-18 17:56:38 UTC 
This commit was included in the shipped 7.3.2 rpm, but this bz didn't make it into the errata. Sorry about that.

I'll move this to MODIFIED to get it into the 7.3.3 QE process.
Comment 9 Luwen Su 2017-02-19 19:30:36 UTC 
In docker-1.12.6-5.el7.x86_64, there is no `dm.use_deferred_deletion` option,

DOCKER_STORAGE_OPTIONS="--storage-driver devicemapper --storage-opt dm.fs=xfs --storage-opt dm.thinpooldev=/dev/mapper/docker_vg-docker--pool --storage-opt dm.use_deferred_removal=true 

Move to verified.
Comment 11 errata-xmlrpc 2017-03-02 19:09:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0406.html