Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1405628

Summary:	Socket search code at startup is slow
Product:	[Community] GlusterFS	Reporter:	kvigor <kvigor>
Component:	transport	Assignee:	kvigor <kvigor>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-05-30 18:38:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description kvigor@fb.com 2016-12-16 21:32:37 UTC

Description of problem:

The iterative search for a socket to bind at startup is slow and of little value to at least one customer. Just bind(0) and let OS assign a port.


Version-Release number of selected component (if applicable):


How reproducible:

Start deamon, feel the slow.

Comment 1 Worker Ant 2016-12-16 21:34:22 UTC

REVIEW: http://review.gluster.org/16178 ([PATCH] Allow OS to assign us a port) posted (#1) for review on master by Kevin Vigor (kvigor)

Comment 2 Worker Ant 2017-03-01 21:37:55 UTC

REVIEW: https://review.gluster.org/16178 (transport: allow OS to assign us a port) posted (#2) for review on master by Jeff Darcy (jdarcy)

Comment 3 Worker Ant 2017-03-10 18:55:42 UTC

REVIEW: https://review.gluster.org/16178 (transport: allow OS to assign us a port) posted (#3) for review on master by Jeff Darcy (jdarcy)

Comment 4 Worker Ant 2017-03-12 15:28:49 UTC

COMMIT: https://review.gluster.org/16178 committed in master by Vijay Bellur (vbellur) 
------
commit eac6dfc314abe4dc50c54bf6c6cc004dfd73d5ac
Author: Kevin Vigor <kvigor>
Date:   Thu Dec 15 13:41:14 2016 -0800

    transport: allow OS to assign us a port
    
    Replace complex and slow port selection code with bind(0) which
    already respects privileged ports.
    
    Change-Id: I408a8528e58e1aafcd32eba6a8f1a759e0bf274e
    BUG: 1405628
    Reviewed-on-release-3.8-fb: http://review.gluster.org/16150
    Signed-off-by: Jeff Darcy <jdarcy>
    Reviewed-on: https://review.gluster.org/16178
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Shyamsundar 2017-05-30 18:38:06 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/