Bug 140585 - [RHEL3][PATCH] SIOCGHWADDR does not clear buffer for ppp connections
Summary: [RHEL3][PATCH] SIOCGHWADDR does not clear buffer for ppp connections
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: kernel
Version: 3.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John W. Linville
QA Contact: Brian Brock
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-11-23 19:03 UTC by Peter Martuccelli
Modified: 2007-11-30 22:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2005-05-18 13:28:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2005:294 0 normal SHIPPED_LIVE Moderate: Updated kernel packages available for Red Hat Enterprise Linux 3 Update 5 2005-05-18 04:00:00 UTC

Description Peter Martuccelli 2004-11-23 19:03:48 UTC
Calling the SIOCGHWADDR ioctl on a ppp connection (specifically Dell's
racser ppp) returns success but does not place data into the request
buffer.  Therefore if the buffer was not cleared prior to the ioctl,
the result buffer will contain garbage data.  The ioctl should either
fail or clear the buffer.
----------
Action by: jordan_hargrave
Issue Registered
----------
Action by: fhirtz


fhirtz assigned to issue for Dell-Engineering.

Category set to: Kernel
Status set to: Waiting on Tech

----------
Action by: mdomsch
Patch for 2.4.21-20.EL.  Please apply to the earliest possible errata,
RHEL3 U5 if not sooner.
Similar patch submitted to netdev.com to apply to 2.6, I'll
open a separate RHEL4 tracker.

File uploaded: net-core-dev.c-2.4.21-20.patch

----------
Action by: fhirtz


Summary edited.

----------
Action by: fhirtz



Issue escalated to Support Engineering Group by: fhirtz.

----------
Action by: wcheng
It would be nice if we have a test case associated with this. 

wcheng assigned to issue for Support Engineering Group.

----------
Action by: fhirtz
Would there happen to be a simple test case for this problem that we
could replicate with?

Status set to: Waiting on Client

----------
Action by: mdomsch
Anything that calls ioctl(SIOCGIFHWADDR) on the ppp0 device, without
first clearing out the request structure, will see it.  Our test case
was doing an snmpwalk command that returns the MAC address of the ppp0
device.  You've obviously got to have a ppp connection established at
the time to see this.


----------
Action by: mdomsch
Frank, can we get this escalated into bugzilla?  David Miller applied
my patch to 2.6, and we want this fixed in RHEL3 too.

Status set to: Waiting on Tech

----------
Action by: mdomsch
Escalated to Bugzilla
----------
Action by: mdomsch
Escalated to Bugzilla
----------
Action by: mdomsch
Escalated to Bugzilla
----------
Action by: mdomsch
Escalated to Bugzilla
----------
Action by: mdomsch
Escalated to Bugzilla
----------
Action by: wcheng
Well, in this case, we'll just escalate the issue.


Issue escalated to Sustaining Engineering by: wcheng.

----------
Action by: wcheng
SE, David Miller had applied this patch to 2.6 and the customer wants
the fix into RHEL 3.


----------
Action by: fhirtz
Matt,

We don't escalate directly into bugzilla from here. It goes into
engineering through a different process through IT. It's been
escalated for evaluation against RHEL3.


----------
Action by: bennet
Assigning to Peter for evaluation and consideration into
RHEL3.

peterm assigned to issue for Sustaining Engineering.

----------
Action by: peterm
Escalated to Bugzilla

Comment 3 John W. Linville 2004-11-29 14:37:01 UTC

*** This bug has been marked as a duplicate of 140616 ***

Comment 4 Ernie Petrides 2004-12-23 23:13:54 UTC
A fix for this problem has just been committed to the RHEL3 U5
patch pool this evening (in kernel version 2.4.21-27.5.EL).


Comment 5 Tim Powers 2005-05-18 13:28:41 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-294.html



Note You need to log in before you can comment on or make changes to this bug.