Bug 1406040 (RR_kf5-syntax-highlighting) - Review Request: kf5-syntax-highlighting - KDE Frameworks 5 Syntax highlighting engine for Kate syntax definitions
Summary: Review Request: kf5-syntax-highlighting - KDE Frameworks 5 Syntax highlightin...
Keywords:
Status: CLOSED RAWHIDE
Alias: RR_kf5-syntax-highlighting
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kde-reviews
TreeView+ depends on / blocked
 
Reported: 2016-12-19 14:38 UTC by Rex Dieter
Modified: 2022-03-01 13:47 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-12-21 00:17:14 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Rex Dieter 2016-12-19 14:38:05 UTC
Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-syntax-highlighting.spec
SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-syntax-highlighting-5.29.0-1.fc24.src.rpm
Description: KDE Frameworks 5 Syntax highlighting engine for Kate syntax definitions
Fedora Account System Username: rdieter

Comment 1 Rex Dieter 2016-12-19 14:38:35 UTC
Scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=16959017

Comment 2 Neal Gompa 2016-12-19 14:41:02 UTC
Taking this review.

Comment 3 Neal Gompa 2016-12-19 18:05:23 UTC
Review notes:

- Builds properly
- Package is named correctly
- Consistent with other KF5 packages
- Licensing is appropriately noted
- Follows Fedora Packaging Guidelines

PACKAGE APPROVED.

Comment 4 Rex Dieter 2016-12-19 18:10:51 UTC
pkgdb request submitted

Comment 5 Gwyn Ciesla 2016-12-20 13:46:45 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-syntax-highlighting

Comment 6 Rex Dieter 2016-12-21 00:17:14 UTC
imported, thanks.

Comment 7 Michal Ambroz 2022-03-01 13:47:01 UTC
removing alias kf5-syntax-highlighting to be able to search for the bugs related to the package


Note You need to log in before you can comment on or make changes to this bug.