RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1406442 - libvirt no longer generates the cephx auth secret when hot plugging virtio-scsi devices
Summary: libvirt no longer generates the cephx auth secret when hot plugging virtio-sc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: x86_64
OS: Linux
urgent
urgent
Target Milestone: rc
: ---
Assignee: John Ferlan
QA Contact: lijuan men
URL:
Whiteboard:
: 1406463 (view as bug list)
Depends On:
Blocks: 1411398
TreeView+ depends on / blocked
 
Reported: 2016-12-20 14:26 UTC by Mike Lowe
Modified: 2020-05-14 15:29 UTC (History)
16 users (show)

Fixed In Version: libvirt-3.0.0-1.el7
Doc Type: Bug Fix
Doc Text:
Cause: Missed code path to add secret for a virtio-scsi during alterations to support domain master secret for encrypted secret passing to qemu. Consequence: Cannot hot plug a virtio-scsi device using cephx authentication. Fix: Adjusted the algorithm to add the authentication object with the encrypted secret for qemu to parse. Result: Capability restored to authenticate hotplug'd virtio-scsi device.
Clone Of:
: 1411398 (view as bug list)
Environment:
Last Closed: 2017-08-01 17:19:14 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:1846 0 normal SHIPPED_LIVE libvirt bug fix and enhancement update 2017-08-01 18:02:50 UTC

Description Mike Lowe 2016-12-20 14:26:38 UTC 
Description of problem:
When attaching a ceph rbd block device with ceph authx enabled to a running vm using the virtio-scsi driver the cephx auth secret is no longer added causing the attachment to fail with "No secret with id 'scsi0-0-0-1-secret0'" or similar and if using openstack "libvirtError: internal error: unable to execute QEMU command '__com.redhat_drive_add': Device 'drive-scsi0-0-0-1' could not be initialized" in the nova-compute.log.  This problem is discussed in this thread on the libvirt mailing list https://www.redhat.com/archives/libvir-list/2016-October/msg00396.html The libvirt version that shipped with 7.2 (1.2.17) did not have this problem.  

Version-Release number of selected component (if applicable):
2.0.0-10.el7_3.2

How reproducible:
Very, will likely affect every openstack deployment using ceph on rhel 7.3

Steps to Reproduce:
1.  Create a vm with virtio-scsi and ceph rbd root disk with cephx auth enabled
2.  use libvirt to attach a second virtio-scsi rbd device 
3.

Actual results:
Device attachment fails with the /var/log/libvirt/qemu log containing "No secret with id 'scsi0-0-0-1-secret0'" and if using openstack nova-compute log contains "libvirtError: internal error: unable to execute QEMU command '__com.redhat_drive_add': Device 'drive-scsi0-0-0-1' could not be initialized"


Expected results:
device attachment to complete successfully without error

Additional info:
Comment 1 Jiri Denemark 2016-12-20 19:19:54 UTC 
*** Bug 1406463 has been marked as a duplicate of this bug. ***
Comment 3 Mike Lowe 2016-12-20 19:24:53 UTC 
I was able to build and install rpms from this srpm https://libvirt.org/sources/libvirt-2.5.0-1.fc24.src.rpm and it seems to resolve this issue as it includes this commit from upstream https://libvirt.org/git/?p=libvirt.git;a=commit;h=0701abcb3ba78ba27cf1f47e01b3d9607ad37b72
Comment 4 John Ferlan 2016-12-21 20:56:42 UTC 
Referenced commit '0701abcb3' seems to resolve the issue. That commit is already upstream as of libvirt-2.4.0 which will be in the the next RHEL 7.4

POSTed patch upstream using this bz for 7.3.z:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2016-December/msg00231.html
Comment 7 lijuan men 2017-01-05 09:23:43 UTC 
I will update our test status in libvirt:

1.I can reproduce the bug in  libvirt-2.0.0-10.el7_3.2

2.I have tested the patch in comment 4,not found new bugs.
Comment 11 lijuan men 2017-02-15 07:00:03 UTC 
verify the bug

version:
libvirt-3.0.0-1.el7.x86_64
qemu-kvm-rhev-2.8.0-3.el7.x86_64

steps:

scenario 1:

1.prepare an auth enabled  ceph environment

2.start a guest with the following xml:
...
  <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/var/lib/libvirt/images/beifen.qcow2'/>
      <target dev='sda' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
...
 <controller type='scsi' index='0' model='virtio-scsi'>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
    </controller>
...

3.attach a device with the xml:
# cat ceph-disk.xml 
 <disk type='network' device='disk'>
      <driver name='qemu' type='raw' cache='none'/>
      <auth username='libvirt'>
        <secret type='ceph' usage='client.ceph'/>
      </auth>
      <source protocol='rbd' name='lmen/vol.img'>
        <host name='10.73.75.52'/>
      </source>
      <target dev='sdb' bus='scsi'/>
    </disk>

# virsh attach-device qq ceph-disk.xml 
Device attached successfully

[root@localhost ~]# virsh domblklist qq
Target     Source
------------------------------------------------
sda        /var/lib/libvirt/images/beifen.qcow2
sdb        lmen/vol.img

4.in the guest,
the second disk can be found and used.


scenario 2:
1.prepare an auth enabled  ceph environment

2.start a guest with the following xml:
...
  <disk type='file' device='disk'>
      <driver name='qemu' type='qcow2'/>
      <source file='/var/lib/libvirt/images/beifen.qcow2'/>
      <target dev='sda' bus='scsi'/>
      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
    </disk>
...
*** <controller type='scsi' index='0'>***
      <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
    </controller>
...

3.attach a device with the xml:
# cat ceph-disk.xml 
 <disk type='network' device='disk'>
      <driver name='qemu' type='raw' cache='none'/>
      <auth username='libvirt'>
        <secret type='ceph' usage='client.ceph'/>
      </auth>
      <source protocol='rbd' name='lmen/vol.img'>
        <host name='10.73.75.52'/>
      </source>
      <target dev='sdb' bus='scsi'/>
    </disk>

# virsh attach-device qq ceph-disk.xml 
Device attached successfully

# virsh domblklist qq
Target     Source
------------------------------------------------
sda        /var/lib/libvirt/images/beifen.qcow2
sdb        lmen/vol.img


4.in the guest,
the second disk can be found and used.
Comment 17 errata-xmlrpc 2017-08-01 17:19:14 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Comment 18 errata-xmlrpc 2017-08-01 23:59:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846
Note You need to log in before you can comment on or make changes to this bug.