Bug 1406989

Created attachment 1234590 [details]
The session log to show the bug

Description of problem:
When viewing the details of the last repo sync with rhui-manager,
traceback log is displayed vertically and hard to read the traceback log
if some errors occurred during the sync.

Here is an example session log:

[root@rhua-3-1 ~]# umount /var/lib/rhui/remote_share/   # To cause sync error on purpose
[root@rhua-3-1 ~]# pulp-admin login -u admin -p ******************************
Successfully logged in. Session certificate will expire at Dec 28 11:06:40 2016 GMT.

[root@rhua-3-1 ~]# pulp-admin rpm repo sync  status --repo-id rhel-6-server-rhui-rpms-6Server-x86_64
+----------------------------------------------------------------------+
       Repository Status [rhel-6-server-rhui-rpms-6Server-x86_64]
+----------------------------------------------------------------------+

The repository is not performing any operations

[root@rhua-3-1 ~]# pulp-admin rpm repo sync run --bg --repo-id rhel-6-server-rhui-rpms-6Server-x86_64
+----------------------------------------------------------------------+
   Synchronizing Repository [rhel-6-server-rhui-rpms-6Server-x86_64]
+----------------------------------------------------------------------+

The request has been queued on the server.

[root@rhua-3-1 ~]# cat << EOF | rhui-manager
> s
> vr
> 1
> q
> EOF


------------------------------------------------------------------------------
             -= Red Hat Update Infrastructure Management Tool =-


-= Home =-

   r   manage repositories
   c   manage content delivery servers (CDS)
   l   manage HAProxy load-balancer instances
   s   synchronization status and scheduling
   e   create entitlement certificates and client configuration RPMs
   n   manage Red Hat entitlement certificates
   u   manage RHUI users

   logout
       removes stored authentication credentials and exits

   <   move to the previous screen
   ^, home
       move to the home screen
   /, clear
       clears the screen
   ?, help
       display help
   q, quit, exit
       exit

                                                Connected: rhua-3-1.example.jp
------------------------------------------------------------------------------

rhui (home) =>
------------------------------------------------------------------------------
             -= Red Hat Update Infrastructure Management Tool =-


-= Synchronization Status =-

   dr  display repo sync summary
   vr  view the details of the last repository sync
   sr  sync an individual repository immediately

                                                Connected: rhua-3-1.example.jp
------------------------------------------------------------------------------
rhui (sync) =>
Select a repository:
  1  - Red Hat Enterprise Linux 6 Server - Optional from RHUI (RPMs) (6Server-x86_64)
  2  - Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server-x86_64)
  3  - Red Hat Enterprise Linux 7 Server - Optional from RHUI (RPMs) (7Server-x86_64)

                                                Connected: rhua-3-1.example.jp
------------------------------------------------------------------------------
rhui (sync) =>
Select a repository:
  1  - Red Hat Enterprise Linux 6 Server - Optional from RHUI (RPMs) (6Server-x8
6_64)
  2  - Red Hat Enterprise Linux 6 Server from RHUI (RPMs) (6Server-x86_64)
  3  - Red Hat Enterprise Linux 7 Server - Optional from RHUI (RPMs) (7Server-x8
6_64)
  4  - Red Hat Enterprise Linux 7 Server from RHUI (RPMs) (7Server-x86_64)
Enter value (1-4) or 'b' to abort:
  Start Time:     12-21-2016 15:33
  Finish Time:    12-21-2016 15:34
  Elapsed Time:   0:01:34
  Result:         Success
  Traceback:
T
r
a
c
e
b
a
c
k

(
m
o
s
t

r
e
c
e
n
t

c
a
l
l

l
a
s
t
)
:




F
i
l
e

"
/
u
s
r
/
l
i
b
/
p
y
t
h
o
n
2
.
7
/
s
i
t
e
-
p
a
c
k
a
g
e
s
/
c
e
l
e
r
y
/
a
p
p
/
t
r
a
c
e
.
p
y
"
,

l
i
n
e

2
4
0
,

i
n

t
r
a
c
e
_
t
a
s
k






R

=

r
e
t
v
a
l

=

f
u
n
(
*
a
r
g
s
,

*
*
k
w
a
r
g
s
)




F
i
l
e

"
/
u
s
r
/
l
i
b
/
p
y
t
h
o
n
2
.
7
/
s
i
t
e
-
p
a
c
k
a
g
e
s
/
p
u
l
p
/
s
e
r
v
e
r
/
a
s
y
n
c
/
t
a
s
k
s
.
p
y
"
,

l
i
n
e

4
7
3
,

i
y
"
,

l
i
n
e

4
7
3
,

i
n

_
_
c
a
l
l
_
_






r
e
t
u
r
n

s
u
p
e
r
(
T
a
s
k
,

s
e
l
f
)
.
_
_
c
a
l
l
_
_
(
*
a
r
g
s
,

*
*
k
w
a
r
g
s
)




F
i
l
e

"
/
u
s
r
/
l
i
b
/
p
y
t
h
o
n
2
.
7
/
s
i
t
e
-
p
a
c
k
a
g
e
s
/
p
u
l
p
/
s
e
r
v
e
r
/
a
s
y
n
c
/
t
a
s
k
s
.
p
y
"
,

l
i
n
e

1
0
3
,

i
n

_
_
c
a
l
l
_
_






r
e
t
u
r
n

s
u
p
e
r
(
P
u
l
p
T
a
s
k
,


[root@rhua-3-1 ~]#



Version-Release number of selected component (if applicable):
3.0 Beta.1 and the latest snapshot (20161220)

How reproducible:
Always if some errors occurred during the sync


Steps to Reproduce:
1. Do something (e.g. umount /var/lib/rhui/remote_share/) causing the repo sync error later
2. Sync the repo, e.g. pulp-admin rpm repo sync run --bg --repo-id rhel-6-server-rhui-rpms-6Server-x86_64 or sync a repo with rhui-manager (s, sr, ...)
3. View the details of the repo sync

Actual results:
Traceback log is displayed vertically.


Expected results:
Traceback log is displayed as it is.


Additional info:
I'll attach a log to show the bug [1], a log to show a couple of possible
fixes [2][3] and a log to prove any of fixes resolve this issue [4].

The root cause is that the code try to join traceback log (item.traceback)
with '\n' although its type may not be [str] but str ([char]), I guess. 

[1] rhui-3_rhui-manager_traceback_on_repo_sync_status_details_0.txt
[2] rhui-3_rhui-manager_traceback_on_repo_sync_status_details_fix_1.txt
[3] rhui-3_rhui-manager_traceback_on_repo_sync_status_details_fix_2.txt
[4] rhui-3_rhui-manager_traceback_on_repo_sync_status_details_1.txt