Red Hat Bugzilla – Bug 140790
e100 and e1000 drivers should return EINVAL when ethtool tries to set rx-mini or rx-jumbo
Last modified: 2007-11-30 17:07:05 EST
Description of problem:
Currently, ethtool calls to e100 or e1000 to set rx-mini or rx-jumbo appear to
succeed although nothing is actually done. This behavior can be misconstrued as
successful setting of the parameter(s). The drivers should be either add support
for setting these values or return EINVAL.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. run 'ethtool -G eth1 rx-mini 64' or 'ethtool -G eth1 rx-jumbo 64' on an e100
2. check adapter's settings to verify the change was not made ('ethtool -g eth1')
Nothing was changed as the rx-mini and rx-jumbo settings are ignored by the
drivers' ethtool handlers.
Either adjust the settings as requested or issue an error indicating lack of
support for the adjustment of given parameter.
Created attachment 107431 [details]
Patch to reject unsupported setting of rx-mini or rx-jumbo in e100 (against U4-Beta kernel)
I can add a similar patch for e1000 if requested.
A fix for this problem has just been committed to the RHEL3 U5
patch pool this afternoon (in kernel version 2.4.21-27.6.EL).
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.