Bug 140790 - (IT_54960) e100 and e1000 drivers should return EINVAL when ethtool tries to set rx-mini or rx-jumbo
e100 and e1000 drivers should return EINVAL when ethtool tries to set rx-mini...
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: kernel (Show other bugs)
3.0
All Linux
medium Severity medium
: ---
: ---
Assigned To: John W. Linville
Brian Brock
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2004-11-24 17:46 EST by David Lehman
Modified: 2007-11-30 17:07 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-05-18 09:28:43 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to reject unsupported setting of rx-mini or rx-jumbo in e100 (against U4-Beta kernel) (592 bytes, patch)
2004-11-24 17:46 EST, David Lehman
no flags Details | Diff

  None (edit)
Description David Lehman 2004-11-24 17:46:41 EST
Description of problem:
Currently, ethtool calls to e100 or e1000 to set rx-mini or rx-jumbo appear to
succeed although nothing is actually done. This behavior can be misconstrued as
successful setting of the parameter(s). The drivers should be either add support
for setting these values or return EINVAL.

Version-Release number of selected component (if applicable):
kernel-2.4.21-20

How reproducible:
Always

Steps to Reproduce:
1. run 'ethtool -G eth1 rx-mini 64' or 'ethtool -G eth1 rx-jumbo 64' on an e100
or e1000
2. check adapter's settings to verify the change was not made ('ethtool -g eth1')
3.
  
Actual results:
Nothing was changed as the rx-mini and rx-jumbo settings are ignored by the
drivers' ethtool handlers.

Expected results:
Either adjust the settings as requested or issue an error indicating lack of
support for the adjustment of given parameter.

Additional info:
Comment 1 David Lehman 2004-11-24 17:46:41 EST
Created attachment 107431 [details]
Patch to reject unsupported setting of rx-mini or rx-jumbo in e100 (against U4-Beta kernel)
Comment 2 David Lehman 2004-11-24 17:47:57 EST
I can add a similar patch for e1000 if requested.
Comment 5 Ernie Petrides 2005-01-06 14:19:53 EST
A fix for this problem has just been committed to the RHEL3 U5
patch pool this afternoon (in kernel version 2.4.21-27.6.EL).
Comment 6 Tim Powers 2005-05-18 09:28:43 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-294.html

Note You need to log in before you can comment on or make changes to this bug.