RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1408331 - policycoreutils-python: moduleRecords.update - 'module' is not defined
Summary: policycoreutils-python: moduleRecords.update - 'module' is not defined
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: policycoreutils
Version: 7.3
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Vit Mojzis
QA Contact: Milos Malik
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-22 23:54 UTC by Ludek Finstrle
Modified: 2018-10-30 09:47 UTC (History)
6 users (show)

Fixed In Version: policycoreutils-2.5-23.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1412998 (view as bug list)
Environment:
Last Closed: 2018-10-30 09:46:22 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:3098 0 None None None 2018-10-30 09:47:11 UTC

Description Ludek Finstrle 2016-12-22 23:54:14 UTC
Description of problem:
When I call method modify in class moduleRecords I receive exception:

# python test.py 
Traceback (most recent call last):
  File "test.py", line 9, in <module>
    semodule.modify(path)
  File "/usr/lib/python2.7/site-packages/seobject/__init__.py", line 415, in modify
    if not module:
NameError: global name 'module' is not defined

When I take a look inside the file for the method definition I see first 3 lines:
        def modify(self, file):
               if not module:
                   raise ValueError(_("You did not define module name."))

I see no reason to use module in modify method. When I comment out lines mentioned module (just the if and raise lines) everything is going perfect.


Version-Release number of selected component (if applicable):
RHEL 7.3, policycoreutils-python-2.5-9.el7.x86_64


How reproducible:
Write a small script test.py which use moduleRecords.update, run it and you'll see.
test.py:

#!/usr/bin/python

import selinux
import seobject

path = '/some/path/to/selinux/semodule.pp'

semodule = seobject.moduleRecords('')
semodule.modify(path)


Steps to Reproduce:
1. create test.py (content above)
2. run it: python test.py


Actual results:
Exception thrown.


Expected results:
Update of the semodule.pp


Additional info:
None

Comment 2 Petr Lautrbach 2017-01-02 13:32:06 UTC
Thanks for the report and the investigation. This error was accidentally introduced by the following commit https://github.com/fedora-selinux/selinux/commit/3d4b60af6aae47874fb02e92c0521e2ef7612d81

We will address this problem in the next minor update.

Comment 8 errata-xmlrpc 2018-10-30 09:46:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3098


Note You need to log in before you can comment on or make changes to this bug.