Bug 1408434 - Slow shutdown
Summary: Slow shutdown
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: tlp
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeremy Newton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-23 11:44 UTC by Biji
Modified: 2017-12-12 10:26 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-12-12 10:26:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Biji 2016-12-23 11:44:47 UTC
Description of problem:
When TLP installed, Fedora 25 shutdown slower


Version-Release number of selected component (if applicable):


How reproducible:
To try: systemctl stop tlp
It will be very slow
Run : ps 
We can see, nmcli process hanging



Thanks 

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:



Additional info:

Comment 1 Jeremy Newton 2016-12-23 16:26:31 UTC
I will notify upstream about this.

But, can you provide me with some information?

1. Does the problem occur on battery or AC or both?
2. Attach the *full* output of `tlp-stat`

Thanks!

Comment 2 Biji 2016-12-27 10:48:50 UTC
Hi Jeremy, 
this is more info:

1) Yes
2) https://paste.fedoraproject.org/513628/83564914/

Found workaround by commenting this line in config:
DEVICES_TO_DISABLE_ON_LAN_CONNECT="wifi wwan"


Thanks

Comment 3 Jeremy Newton 2016-12-31 05:07:57 UTC
This issue has been moved upstream:

https://github.com/linrunner/TLP/issues/242

Thanks for reporting it!

Comment 4 Jeremy Newton 2017-01-17 15:04:49 UTC
The developer has commented on the upstream bug report:

> Hi,
>
> am i right to assume the delay occurs when the lan cable is connected and thus wifi is off? In this state TLP will turn on wifi during shutdown.
>
> Please try if the delay occurs with:
>
>  wifi on

Please test and let me know, or reply directly to the bug report if you wish.

Comment 5 Jeremy Newton 2017-01-17 15:06:13 UTC
Changing back to assigned/open, as I cannot repro this issue. Also CC-ing developer.

Comment 6 Thomas Koch 2017-01-17 19:35:01 UTC
This is definitely not a general issue with the feature. I suspect a wifi driver / rfkill issue.

@Biji: i would prefer to discuss the issue in the upstream bug report only

Comment 7 Thomas Koch 2017-03-19 14:27:56 UTC
Cause: 'systemctl stop tlp' invokes 'nmcli radio on <device>' in systemd
context. This causes nmcli to hang for ~20 sec *after* switching the device.

'tlp init stop' or 'nmcli radio on <device>' in a shell doesn't hang.

Workaround for 0.9 --> https://github.com/linrunner/TLP/commit/dabd0e900f6e10c358436c584c51dd1f55c320d2

@Jeremy : would you advise to open a bug against NM for that?

Comment 8 Jeremy Newton 2017-03-20 15:35:00 UTC
(In reply to Thomas Koch from comment #7)
> Cause: 'systemctl stop tlp' invokes 'nmcli radio on <device>' in systemd
> context. This causes nmcli to hang for ~20 sec *after* switching the device.
> 
> 'tlp init stop' or 'nmcli radio on <device>' in a shell doesn't hang.
> 
> Workaround for 0.9 -->
> https://github.com/linrunner/TLP/commit/
> dabd0e900f6e10c358436c584c51dd1f55c320d2
> 
> @Jeremy : would you advise to open a bug against NM for that?

Hmm maybe, I'm not sure, but making a bug report may get the right people involved to get this fixed.

Can you repro this issue easily? If so, is this just a Fedora issue or is this reproducible on other distros?

In the meantime, I'll push and update with this workaround.

Comment 9 Thomas Koch 2017-03-20 18:57:06 UTC
This is the only report so far. Nothing from Debian/Ubuntu and Arch users.

It's easy to reproduce (on any laptop i suppose):

1. Install tlp, tlp-rdw
2. Configure: DEVICES_TO_ENABLE_ON_SHUTDOWN="wifi" 
3. Reboot or: systemctl start tlp
4. Disable wifi: wifi off
5. systemctl stop tlp

Could you check F26 and/or rawhide too?

Comment 10 Jeremy Newton 2017-03-21 04:25:07 UTC
I'll see if I can repro this on my laptop when I have time. I would like to see if this also affects other distros to see if I should make a bug here or in the upstream bug tracker.

I made an update with the workaround patch, I'll push it shortly.

Comment 11 Fedora Update System 2017-03-21 04:28:47 UTC
tlp-0.9-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-90768381ad

Comment 12 Fedora Update System 2017-03-21 04:28:54 UTC
tlp-0.9-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-817320cac3

Comment 13 Fedora Update System 2017-03-21 04:28:58 UTC
tlp-0.9-5.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-bd706dd5c0

Comment 14 Fedora Update System 2017-03-21 14:26:25 UTC
tlp-0.9-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-817320cac3

Comment 15 Fedora Update System 2017-03-21 17:53:17 UTC
tlp-0.9-5.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-bd706dd5c0

Comment 16 Fedora Update System 2017-03-21 17:55:05 UTC
tlp-0.9-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-90768381ad

Comment 17 Fedora Update System 2017-03-26 21:23:39 UTC
tlp-0.9-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2017-03-30 00:21:58 UTC
tlp-0.9-5.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2017-04-01 17:20:12 UTC
tlp-0.9-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora End Of Life 2017-11-16 18:51:43 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 21 Thomas Koch 2017-11-19 14:38:51 UTC
Problem is caused by SELinux AVCs and solved for F26 an higher, refer to https://bugzilla.redhat.com/show_bug.cgi?id=1403782

I think we should close here.

Comment 22 Thomas Koch 2017-11-21 17:10:08 UTC
Btw: tested with 3.13.1-260.14. No AVCs.

Comment 23 Fedora End Of Life 2017-12-12 10:26:37 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.