Bug 1408445

Cloned bug was closed as duplicate however it was only partially fixed. `puppetclass` parameter now has same name for both POST and GET requests, while `host_parameters_attributes` still used for POST and `parameters` for GET.

Below is modified description of cloned bug to describe current situation.

+++ This bug was initially created as a clone of Bug #1235019 +++

Description of problem:
When issuing a POST request to /api/v2/hosts, you can provide the following attributes, among others:

* host_parameters_attributes

When issuing a GET request to /api/v2/hosts/:id, the following attributes are returned:

* parameters

This mis-match between attribute names when issuing POST and GET requests is troublesome and forces API clients to write up manual hacks. POST and GET requests should return identically named attributes.

POST request, sending `parameters` as data:
> 2016-12-23 13:59:38 - nailgun.client - DEBUG - Making HTTP POST request to https://sat6.com/api/v2/hosts with ... and data {... "parameters": [{"name": "value"}], ...}.

Response, `parameters` is empty and `host_parameters_attributes` is missing:
> 2016-12-23 13:59:39 - nailgun.client - DEBUG - Received HTTP 201 response: {...,"parameters":[],"all_parameters":[], ... }

GET request, `parameters` is empty and `host_parameters_attributes` is missing:
> 2016-12-23 14:05:53 - nailgun.client - DEBUG - Making HTTP GET request to https://sat6.com/api/v2/hosts/37 with ... and no data.
> 2016-12-23 14:05:54 - nailgun.client - DEBUG - Received HTTP 200 response: {...,"parameters":[],"all_parameters":[], ...}

POST request, sending `host_parameters_attributes` as data:
> 2016-12-23 14:08:02 - nailgun.client - DEBUG - Making HTTP POST request to https://sat6.com/api/v2/hosts with ... and data {" "host_parameters_attributes": [{"name": "value"}], ...}.

Response, `parameters` not empty:
> 2016-12-23 14:08:04 - nailgun.client - DEBUG - Received HTTP 201 response: {..., "parameters":[{"id":6,"name":"value","value":null}],"all_parameters":[{"id":6,"name":"value","value":null}], ...}


Version-Release number of selected component (if applicable):
Satellite 6.3 Snap 8 / Foreman 1.13.2.2-1

How reproducible:
100%

Steps to Reproduce:
1. Create a host by issuing a POST request to /api/v2/hosts.
2. Read a host by issuing a GET request to /api/v2/hosts/:id.
3. Discover that the POST request accepts differently named parameters than the GET request.

Actual results:
POST and GET work with differently named parameters.

Expected results:
POST and GET work with identically named parameters.

Additional info:


--- Additional comment from alon on 2015-07-14 08:20:30 EDT ---

Fixed in http://projects.theforeman.org/issues/10356