Spec URL: https://github.com/chkumar246/python-shaker/blob/rpm-master/python-shaker.spec SRPM URL: https://chandankumar.fedorapeople.org/python-shaker-0.0.16-1.fc25.src.rpm Description: Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps around popular system network testing tools like iperf < iperf3 < and netperf (with help of flent < Shaker is able to deploy OpenStack instances and networks in different topologies. Shaker scenario specifies the deployment and list of tests to execute. Fedora Account System Username: chandankumar
python-pygal is not available in CBS. So DLRN local build will fail.
As python-pygal is available in CBS. Here is the updated SPEC: https://github.com/chkumar246/python-shaker/blob/rpm-master/python-shaker.spec and SRPM: https://chandankumar.fedorapeople.org/python-shaker-0.0.17-0.20170116135235.27c3fc5.el7.centos.src.rpm
Fixed URLs: SPEC: https://raw.githubusercontent.com/chkumar246/python-shaker/rpm-master/python-shaker.spec SRPM: https://chandankumar.fedorapeople.org/python-shaker-0.0.17-0.20170116135235.27c3fc5.el7.centos.src.rpm
Initial licensecheck output: $ licensecheck -r . ./.dockerignore: *No copyright* UNKNOWN ./.gitreview: *No copyright* UNKNOWN ./.testr.conf: *No copyright* UNKNOWN ./Dockerfile: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache (v2.0) ./README.rst: *No copyright* UNKNOWN ./config-generator.conf: *No copyright* UNKNOWN ./doc-requirements.txt: *No copyright* UNKNOWN ./openstack-common.conf: *No copyright* UNKNOWN ./readthedocs.yml: *No copyright* UNKNOWN ./requirements-agent.txt: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./rtd-requirements.txt: *No copyright* UNKNOWN ./setup-agent.cfg: *No copyright* Apache ./setup.cfg: *No copyright* Apache ./setup.py: Apache (v2.0) GENERATED FILE ./test-requirements.txt: *No copyright* UNKNOWN ./tox.ini: *No copyright* UNKNOWN ./etc/shaker.conf: *No copyright* UNKNOWN ./shaker/lib.py: Apache (v2.0) ./shaker/version.py: Apache (v2.0) ./tools/build_agent_pkg.sh: *No copyright* UNKNOWN ./tools/build_scenario_catalog.py: Apache (v2.0) ./tools/cli_auto_doc.py: Apache (v2.0) ./tools/install_venv.sh: *No copyright* UNKNOWN ./tools/svg2png.sh: *No copyright* UNKNOWN ./tools/with_venv.sh: *No copyright* UNKNOWN ./doc/source/architecture.rst: *No copyright* GENERATED FILE ./doc/source/catalog.rst: *No copyright* UNKNOWN ./doc/source/conf.py: Apache (v2.0) ./doc/source/config.rst: *No copyright* UNKNOWN ./doc/source/contributing.rst: *No copyright* UNKNOWN ./doc/source/examples_spot.rst: *No copyright* UNKNOWN ./doc/source/index.rst: *No copyright* UNKNOWN ./doc/source/installation.rst: *No copyright* UNKNOWN ./doc/source/tools.rst: *No copyright* UNKNOWN ./doc/source/usage.rst: *No copyright* UNKNOWN ./shaker/agent/agent.py: Apache (v2.0) ./shaker/engine/all_in_one.py: *No copyright* Apache (v2.0) ./shaker/engine/config.py: Apache (v2.0) ./shaker/engine/deploy.py: Apache (v2.0) ./shaker/engine/image_builder.py: Apache (v2.0) ./shaker/engine/messaging.py: Apache (v2.0) ./shaker/engine/quorum.py: Apache (v2.0) ./shaker/engine/report.py: Apache (v2.0) ./shaker/engine/server.py: Apache (v2.0) ./shaker/engine/sla.py: Apache (v2.0) ./shaker/engine/spot.py: Apache (v2.0) ./shaker/engine/utils.py: Apache (v2.0) ./shaker/engine/writer.py: Apache (v2.0) ./shaker/tests/test_agent.py: Apache (v2.0) ./shaker/tests/test_deploy.py: Apache (v2.0) ./shaker/tests/test_flent_executor.py: Apache (v2.0) ./shaker/tests/test_iperf_executor.py: Apache (v2.0) ./shaker/tests/test_lib.py: Apache (v2.0) ./shaker/tests/test_netperf_executor.py: Apache (v2.0) ./shaker/tests/test_operations.py: Apache (v2.0) ./shaker/tests/test_quorum.py: Apache (v2.0) ./shaker/tests/test_report.py: Apache (v2.0) ./shaker/tests/test_scenarios.py: Apache (v2.0) ./shaker/tests/test_server.py: Apache (v2.0) ./shaker/tests/test_sla.py: Apache (v2.0) ./shaker/tests/test_traffic_aggregator.py: Apache (v2.0) ./shaker/tests/test_utils.py: Apache (v2.0) ./doc/source/examples/full_l2.rst: *No copyright* UNKNOWN ./doc/source/examples/full_l3_east_west.rst: *No copyright* UNKNOWN ./doc/source/examples/full_l3_north_south.rst: *No copyright* UNKNOWN ./doc/source/examples/index.rst: *No copyright* UNKNOWN ./doc/source/images/accommodation_double_room.png: UNKNOWN ./doc/source/images/accommodation_double_room.svg: *No copyright* UNKNOWN ./doc/source/images/accommodation_single_room.png: UNKNOWN ./doc/source/images/accommodation_single_room.svg: *No copyright* UNKNOWN ./doc/source/images/architecture.png: UNKNOWN ./doc/source/images/architecture.svg: *No copyright* UNKNOWN ./doc/source/images/simultaneous.png: UNKNOWN ./doc/source/images/simultaneous.svg: *No copyright* UNKNOWN ./doc/source/images/topology_l2.png: UNKNOWN ./doc/source/images/topology_l3_east_west.png: UNKNOWN ./doc/source/images/topology_l3_north_south.png: UNKNOWN ./doc/source/k8s/shaker-pod.yaml: *No copyright* UNKNOWN ./doc/source/k8s/shaker-svc.yaml: *No copyright* UNKNOWN ./doc/source/reports/index.rst: *No copyright* UNKNOWN ./doc/source/tools/shaker-agent.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker-all-in-one.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker-cleanup.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker-image-builder.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker-report.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker-spot.txt: *No copyright* UNKNOWN ./doc/source/tools/shaker.txt: *No copyright* UNKNOWN ./shaker/engine/aggregators/__init__.py: Apache (v2.0) ./shaker/engine/aggregators/base.py: Apache (v2.0) ./shaker/engine/aggregators/traffic.py: Apache (v2.0) ./shaker/engine/executors/__init__.py: Apache (v2.0) ./shaker/engine/executors/base.py: Apache (v2.0) ./shaker/engine/executors/flent.py: Apache (v2.0) ./shaker/engine/executors/iperf.py: Apache (v2.0) ./shaker/engine/executors/netperf.py: Apache (v2.0) ./shaker/engine/executors/shell.py: Apache (v2.0) ./shaker/openstack/clients/glance.py: Apache (v2.0) ./shaker/openstack/clients/heat.py: Apache (v2.0) ./shaker/openstack/clients/neutron.py: Apache (v2.0) ./shaker/openstack/clients/nova.py: Apache (v2.0) ./shaker/openstack/clients/openstack.py: Apache (v2.0) ./shaker/resources/image_builder_templates/centos.yaml: *No copyright* UNKNOWN ./shaker/resources/image_builder_templates/debian.yaml: *No copyright* UNKNOWN ./shaker/resources/image_builder_templates/ubuntu.yaml: *No copyright* UNKNOWN ./shaker/resources/image_builder_templates/ubuntu_xenial.yaml: *No copyright* UNKNOWN ./shaker/resources/report_templates/interactive.html: *No copyright* UNKNOWN ./shaker/resources/report_templates/json.html: *No copyright* UNKNOWN ./shaker/resources/schemas/scenario.yaml: *No copyright* UNKNOWN ./shaker/scenarios/misc/instance_metadata.hot: *No copyright* UNKNOWN ./shaker/scenarios/misc/instance_metadata.yaml: *No copyright* UNKNOWN ./shaker/scenarios/misc/static_agent.yaml: *No copyright* UNKNOWN ./shaker/scenarios/misc/static_agents_pair.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/dense_l2.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/dense_l3_east_west.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/dense_l3_north_south.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/full_l2.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/full_l3_east_west.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/full_l3_north_south.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/l2.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/l3_east_west.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/l3_north_south.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/perf_l2.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/perf_l3_east_west.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/perf_l3_north_south.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/udp_l2.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/openstack/udp_l3_east_west.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/openstack/udp_l3_north_south.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/spot/ping.yaml: *No copyright* UNKNOWN ./shaker/scenarios/spot/tcp.yaml: *No copyright* UNKNOWN ./shaker/scenarios/spot/udp.yaml: *No copyright* UNKNOWN ./doc/source/reports/dense_l2/69d3be4d-88d9-49de-8d02-74c90b636410.png: UNKNOWN ./doc/source/reports/dense_l2/69d3be4d-88d9-49de-8d02-74c90b636410.svg: GENERATED FILE ./doc/source/reports/dense_l2/73b640de-a11f-4876-9494-11a2641193b5.png: UNKNOWN ./doc/source/reports/dense_l2/73b640de-a11f-4876-9494-11a2641193b5.svg: GENERATED FILE ./doc/source/reports/dense_l2/ba3c8569-7318-4dc6-ba70-1a45cee0e3e6.png: UNKNOWN ./doc/source/reports/dense_l2/ba3c8569-7318-4dc6-ba70-1a45cee0e3e6.svg: GENERATED FILE ./doc/source/reports/dense_l2/index.rst: *No copyright* UNKNOWN ./doc/source/reports/dense_l3_east_west/b301136d-c6d5-4eb3-8942-be2041bde8e2.png: UNKNOWN ./doc/source/reports/dense_l3_east_west/b301136d-c6d5-4eb3-8942-be2041bde8e2.svg: GENERATED FILE ./doc/source/reports/dense_l3_east_west/dbe5eb6f-351b-4297-88a8-5130f67064c5.png: UNKNOWN ./doc/source/reports/dense_l3_east_west/dbe5eb6f-351b-4297-88a8-5130f67064c5.svg: GENERATED FILE ./doc/source/reports/dense_l3_east_west/fa959708-db0c-40be-9b11-391064e6a003.png: UNKNOWN ./doc/source/reports/dense_l3_east_west/fa959708-db0c-40be-9b11-391064e6a003.svg: GENERATED FILE ./doc/source/reports/dense_l3_east_west/index.rst: *No copyright* UNKNOWN ./doc/source/reports/full_l2/193493d3-7de6-4f3e-976e-3bffc9f5776b.png: UNKNOWN ./doc/source/reports/full_l2/193493d3-7de6-4f3e-976e-3bffc9f5776b.svg: GENERATED FILE ./doc/source/reports/full_l2/7220f722-0c40-4edb-a323-ab9d2df71e1b.png: UNKNOWN ./doc/source/reports/full_l2/7220f722-0c40-4edb-a323-ab9d2df71e1b.svg: GENERATED FILE ./doc/source/reports/full_l2/722a69c0-c3e5-458c-99df-486484b1d481.png: UNKNOWN ./doc/source/reports/full_l2/722a69c0-c3e5-458c-99df-486484b1d481.svg: GENERATED FILE ./doc/source/reports/full_l2/index.rst: *No copyright* UNKNOWN ./doc/source/reports/full_l3_east_west/7db77fbd-ac1b-4f48-9200-992578593598.png: UNKNOWN ./doc/source/reports/full_l3_east_west/7db77fbd-ac1b-4f48-9200-992578593598.svg: GENERATED FILE ./doc/source/reports/full_l3_east_west/971e06b7-59f2-4154-976c-1db0e7f7645f.png: UNKNOWN ./doc/source/reports/full_l3_east_west/971e06b7-59f2-4154-976c-1db0e7f7645f.svg: GENERATED FILE ./doc/source/reports/full_l3_east_west/a5cec469-249a-4d9a-ad2d-51b5ce38de7e.png: UNKNOWN ./doc/source/reports/full_l3_east_west/a5cec469-249a-4d9a-ad2d-51b5ce38de7e.svg: GENERATED FILE ./doc/source/reports/full_l3_east_west/index.rst: *No copyright* UNKNOWN ./doc/source/reports/full_l3_north_south/43db46b3-0536-4c92-b809-4957afe3a794.png: UNKNOWN ./doc/source/reports/full_l3_north_south/43db46b3-0536-4c92-b809-4957afe3a794.svg: GENERATED FILE ./doc/source/reports/full_l3_north_south/73b55d80-654d-438a-8ddd-3d89ce821f38.png: UNKNOWN ./doc/source/reports/full_l3_north_south/73b55d80-654d-438a-8ddd-3d89ce821f38.svg: GENERATED FILE ./doc/source/reports/full_l3_north_south/de257d81-c808-4b8e-bfdb-84c0ae1925e6.png: UNKNOWN ./doc/source/reports/full_l3_north_south/de257d81-c808-4b8e-bfdb-84c0ae1925e6.svg: GENERATED FILE ./doc/source/reports/full_l3_north_south/index.rst: *No copyright* UNKNOWN ./doc/source/reports/perf_l2/1586aa2e-863f-4469-a613-278bcfac8cb2.png: UNKNOWN ./doc/source/reports/perf_l2/1586aa2e-863f-4469-a613-278bcfac8cb2.svg: GENERATED FILE ./doc/source/reports/perf_l2/780d525c-da2d-44d4-aa93-3a73a57714cf.png: UNKNOWN ./doc/source/reports/perf_l2/780d525c-da2d-44d4-aa93-3a73a57714cf.svg: GENERATED FILE ./doc/source/reports/perf_l2/b8de3714-e7f0-4109-8a3c-bfb3071c4f2d.png: UNKNOWN ./doc/source/reports/perf_l2/b8de3714-e7f0-4109-8a3c-bfb3071c4f2d.svg: GENERATED FILE ./doc/source/reports/perf_l2/index.rst: *No copyright* UNKNOWN ./doc/source/reports/perf_l3_east_west/0549ebdf-5903-4592-ab06-5c12b10fc625.png: UNKNOWN ./doc/source/reports/perf_l3_east_west/0549ebdf-5903-4592-ab06-5c12b10fc625.svg: GENERATED FILE ./doc/source/reports/perf_l3_east_west/489cd75f-c740-477f-9e03-9e0adf043ccf.png: UNKNOWN ./doc/source/reports/perf_l3_east_west/489cd75f-c740-477f-9e03-9e0adf043ccf.svg: GENERATED FILE ./doc/source/reports/perf_l3_east_west/c27bc4a9-b379-4f18-bcff-ff24e1f35ead.png: UNKNOWN ./doc/source/reports/perf_l3_east_west/c27bc4a9-b379-4f18-bcff-ff24e1f35ead.svg: GENERATED FILE ./doc/source/reports/perf_l3_east_west/index.rst: *No copyright* UNKNOWN ./doc/source/reports/perf_l3_north_south/42af5820-53ae-4dcb-a268-b59c046698a5.png: UNKNOWN ./doc/source/reports/perf_l3_north_south/42af5820-53ae-4dcb-a268-b59c046698a5.svg: GENERATED FILE ./doc/source/reports/perf_l3_north_south/44aea6a5-541d-43a0-a331-42fdcada8ac6.png: UNKNOWN ./doc/source/reports/perf_l3_north_south/44aea6a5-541d-43a0-a331-42fdcada8ac6.svg: GENERATED FILE ./doc/source/reports/perf_l3_north_south/4effd839-3d1a-49ab-a9e0-9ad4f2a1434e.png: UNKNOWN ./doc/source/reports/perf_l3_north_south/4effd839-3d1a-49ab-a9e0-9ad4f2a1434e.svg: GENERATED FILE ./doc/source/reports/perf_l3_north_south/index.rst: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/full_l2.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/full_l3_east_west.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/full_l3_north_south.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/l2.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/l3_east_west.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/l3_north_south.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/perf_l2.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/perf_l3_east_west.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/perf_l3_north_south.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/cross_az/udp_l2.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/openstack/cross_az/udp_l2_mss8950.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/openstack/cross_az/udp_l3_east_west.yaml: *No copyright* GENERATED FILE ./shaker/scenarios/openstack/external/dense_l3_north_south_no_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/dense_l3_north_south_with_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/full_l3_north_south_no_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/full_l3_north_south_with_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/l3_north_south_no_fip.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/l3_north_south_with_fip.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/perf_l3_north_south_no_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/external/perf_l3_north_south_with_fip.yaml: *No copyright* UNKNOWN ./shaker/scenarios/openstack/qos/l2_qos.hot: *No copyright* UNKNOWN ./shaker/scenarios/openstack/qos/perf_l2.yaml: *No copyright* UNKNOWN The project is licensed using the Apache 2.0 license.
These are the resulting files after the Gerrit review: Spec: https://raw.githubusercontent.com/rdo-packages/shaker-distgit/rpm-master/python-shaker.spec SRPM: http://46.231.132.68:8080/v1/AUTH_b50e80d3969f441a8b7b1fe831003e0a/rdoartifacts/88/4388/3/gate/DLRN-rpmbuild/Z03e8481551a543ae8fc8aeb4318dbc7a/artifacts/centos/repos/9e/cd/9ecdd57b0fabd11bee6cef9f6f986f9ca00d7973_dev/python-shaker-0.0.17-0.20170124105219.9ecdd57.el7.centos.src.rpm Please note the SRPM has been generated by DLRN, so some differences in the spec (version and release) are expected.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Check did not completechecksum differs and there are problems running diff. Please verify manually. See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 168 files have unknown license. Detailed output of licensecheck in /tmp/shaker/review-python- shaker/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/pyshaker [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/pyshaker [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-shaker , python2-shaker-tests , python-shaker-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python2-shaker-0.0.17-0.20170124105219.9ecdd57.el7.centos.noarch.rpm python2-shaker-tests-0.0.17-0.20170124105219.9ecdd57.el7.centos.noarch.rpm python-shaker-doc-0.0.17-0.20170124105219.9ecdd57.el7.centos.noarch.rpm python-shaker-0.0.17-0.20170124105219.9ecdd57.el7.centos.src.rpm python2-shaker.noarch: W: spelling-error %description -l en_US dataplane -> data plane, data-plane, aquaplane python2-shaker.noarch: W: spelling-error %description -l en_US iperf -> imperf python2-shaker.noarch: W: spelling-error %description -l en_US netperf -> netter python2-shaker.noarch: W: spelling-error %description -l en_US flent -> lent, fluent, fleet python2-shaker.noarch: W: spelling-error %description -l en_US topologies -> typologies, topological python2-shaker.noarch: E: description-line-too-long C Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps python2-shaker.noarch: E: no-changelogname-tag python2-shaker.noarch: E: non-readable /etc/pyshaker/shaker.conf 640 python2-shaker.noarch: W: no-manual-page-for-binary shaker python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup python2-shaker.noarch: W: no-manual-page-for-binary shaker-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-report-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one python2-shaker.noarch: W: no-manual-page-for-binary shaker-report python2-shaker.noarch: W: no-manual-page-for-binary shaker-report-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent python2-shaker-tests.noarch: W: spelling-error %description -l en_US dataplane -> data plane, data-plane, aquaplane python2-shaker-tests.noarch: W: spelling-error %description -l en_US iperf -> imperf python2-shaker-tests.noarch: W: spelling-error %description -l en_US netperf -> netter python2-shaker-tests.noarch: W: spelling-error %description -l en_US flent -> lent, fluent, fleet python2-shaker-tests.noarch: W: spelling-error %description -l en_US topologies -> typologies, topological python2-shaker-tests.noarch: E: description-line-too-long C Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps python2-shaker-tests.noarch: E: no-changelogname-tag python2-shaker-tests.noarch: W: no-documentation python-shaker-doc.noarch: E: no-changelogname-tag python-shaker-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-shaker-doc-0.0.17/html/.buildinfo python-shaker.src: W: spelling-error %description -l en_US dataplane -> data plane, data-plane, aquaplane python-shaker.src: W: spelling-error %description -l en_US iperf -> imperf python-shaker.src: W: spelling-error %description -l en_US netperf -> netter python-shaker.src: W: spelling-error %description -l en_US flent -> lent, fluent, fleet python-shaker.src: W: spelling-error %description -l en_US topologies -> typologies, topological python-shaker.src: E: description-line-too-long C Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps python-shaker.src: E: no-changelogname-tag python-shaker.src: W: invalid-url Source0: pyshaker-0.0.17.dev6-0.20170124105219.9ecdd57.tar.gz 4 packages and 0 specfiles checked; 8 errors, 39 warnings. Rpmlint (installed packages) ---------------------------- python-shaker-doc.noarch: E: no-changelogname-tag python-shaker-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-shaker-doc-0.0.17/html/.buildinfo python2-shaker-tests.noarch: E: description-line-too-long C Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps python2-shaker-tests.noarch: E: no-changelogname-tag python2-shaker-tests.noarch: W: no-documentation python2-shaker.noarch: E: description-line-too-long C Shaker is the distributed dataplane testing tool built for OpenStack. Shaker wraps python2-shaker.noarch: E: no-changelogname-tag python2-shaker.noarch: E: non-readable /etc/pyshaker/shaker.conf 0640L python2-shaker.noarch: W: no-manual-page-for-binary shaker python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent python2-shaker.noarch: W: no-manual-page-for-binary shaker-report-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-report python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-report-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-image-builder python2-shaker.noarch: W: no-manual-page-for-binary shaker-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup python2-shaker.noarch: W: no-manual-page-for-binary shaker-cleanup-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-agent-2 python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-spot-2.7 python2-shaker.noarch: W: no-manual-page-for-binary shaker-all-in-one-2 3 packages and 0 specfiles checked; 6 errors, 23 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/shaker/python-shaker.spec 2017-01-24 17:36:04.372051720 +0100 +++ /tmp/shaker/review-python-shaker/srpm-unpacked/python-shaker.spec 2017-01-24 11:52:19.000000000 +0100 @@ -1,2 +1,4 @@ +%global dlrn 1 +%define upstream_version 0.0.17.dev6 %{!?upstream_version: %global upstream_version %{version}%{?milestone}} %global sname shaker @@ -8,11 +10,11 @@ Name: python-%{sname} -Version: 0.0.17 -Release: 0.20170124105219.9ecdd57 +Version: 0.0.17 +Release: 0.20170124105219.9ecdd57%{?dist} Summary: Distributed data-plane performance testing tool License: ASL 2.0 URL: https://launchpad.net/%{sname}/ -Source0: http://tarballs.openstack.org/%{sname}/%{pypi_name}-%{upstream_version}.tar.gz +Source0: pyshaker-0.0.17.dev6-0.20170124105219.9ecdd57.tar.gz BuildArch: noarch Requires -------- python-shaker-doc (rpmlib, GLIBC filtered): python2-shaker-tests (rpmlib, GLIBC filtered): python(abi) python-coverage python-mock python-oslotest python-testrepository python-testtools python2-shaker python2-shaker (rpmlib, GLIBC filtered): /usr/bin/python2 PyYAML config(python2-shaker) python(abi) python-glanceclient python-heatclient python-iso8601 python-jinja2 python-keystoneauth1 python-neutronclient python-novaclient python-os-client-config python-oslo-concurrency python-oslo-config python-oslo-i18n python-oslo-log python-oslo-serialization python-oslo-utils python-pbr python-psutil python-pygal python-pykwalify python-six python-zmq Provides -------- python-shaker-doc: python-shaker-doc python2-shaker-tests: python2-shaker-tests python2-shaker: config(python2-shaker) python-shaker python2-shaker Source checksums ---------------- http://tarballs.openstack.org/shaker/pyshaker-0.0.17.tar.gz : CHECKSUM(SHA256) this package : ERROR CHECKSUM(SHA256) upstream package : 0ee6af6554024329b47ec524be744f7a51b67de993b55aca078238952d3e7062 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n python-shaker -m dlrn Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 * The differences between the spec from the review and srpm are due to the SRPM being generated by DLRN, so they are expected. Same for the dist tag being present. * The embedded fonts are in the -doc subpackage, it looks like the doc creation process includes them. * The only thing to fix is to remove the sphinx-build leftovers (.buildinfo), but that can be done as a follow-up. See https://github.com/openstack-packages/openstack-example-spec/blob/master/python-example-library.spec#L119-L120 for an example. The package is APPROVED.
python-shaker already being built in RDO Trunk.