Bug 1408465 - libbsd: Turn explicit_bzero, reallocarray into compat symbols
Summary: libbsd: Turn explicit_bzero, reallocarray into compat symbols
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libbsd
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Eric Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora26GlibcInterpositionTracker Fedora27GlibcInterpositionTracker
TreeView+ depends on / blocked
 
Reported: 2016-12-23 14:26 UTC by Florian Weimer
Modified: 2018-05-22 22:28 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-05-22 22:28:10 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
explicit_bzero-compat.patch (318 bytes, patch)
2017-02-01 09:21 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2016-12-23 14:26:00 UTC
It is now provided by glibc.

I think you can keep it as a compat symbol (i.e. a symbol without a default version).

Comment 1 Eric Smith 2016-12-24 05:28:00 UTC
I don't see that any glibc 2.25 builds have been done yet. Do you anticipate that 2.25 (or newer) will be pushed as an update for F25, or will it appear in F26?

Can you point me to an example of how to declare a function as a compat symbol? Does this have to do with GCC's visibility attribute?

Thanks!
Eric

Comment 2 Florian Weimer 2017-02-01 09:21:27 UTC
Created attachment 1246594 [details]
explicit_bzero-compat.patch

The attached patch should turn the symbol into a compat symbol.

Before:

[fweimer@oldenburg libbsd]$ eu-readelf --symbols=.dynsym ./src/.libs/libbsd.so | grep explicit_bzero
  125: 0000000000004c30     39 FUNC    GLOBAL DEFAULT       13 explicit_bzero@@LIBBSD_0.8

The “@@” indicates that this is a default version against which applications can link.

After:

[fweimer@oldenburg libbsd]$ eu-readelf --symbols=.dynsym ./src/.libs/libbsd.so | grep explicit_bzero
  126: 0000000000004c30     39 FUNC    GLOBAL DEFAULT       13 explicit_bzero

The “@@” is gone, meaning that this is a compat symbol.

Comment 3 Fedora End Of Life 2017-02-28 10:50:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 4 Anton Guda 2017-05-12 12:10:37 UTC
It may be worth to remove /usr/share/man/man3/explicit_bzero.3.gz
as well. It conflicts now with man-pages.

Comment 5 Florian Weimer 2017-06-01 08:52:40 UTC
glibc 2.26 also introduces reallocarray, which should be turned into a compatibility symbol as well.

Comment 6 Fedora End Of Life 2018-05-03 08:13:42 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 7 Florian Weimer 2018-05-16 09:30:47 UTC
Still not fixed in rawhide.  This is rather disappointing.


Note You need to log in before you can comment on or make changes to this bug.