Bug 1408500 - gtk3: toolbars borders too distinct vs native gtk3 apps
Summary: gtk3: toolbars borders too distinct vs native gtk3 apps
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: libreoffice
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-23 21:06 UTC by poma
Modified: 2017-01-20 18:07 UTC (History)
6 users (show)

Fixed In Version: libreoffice-5.2.4.2-2.fc25 libreoffice-5.2.4.2-3.fc25
Clone Of:
Environment:
Last Closed: 2017-01-20 18:07:20 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Adwaita's surplus (317.05 KB, image/png)
2017-01-12 10:49 UTC, poma
no flags Details
As a reminder. (1.71 KB, patch)
2017-01-14 18:42 UTC, poma
no flags Details | Diff

Description poma 2016-12-23 21:06:00 UTC
Description of problem:
LibreOffice toolbar border needs further tuning

Version-Release number of selected component (if applicable):
libreoffice-gtk3-5.3.0.0-7.beta2.fc26.x86_64

How reproducible:
Run with a light GTK+ 3 theme

Steps to Reproduce:
1. GTK_THEME=Adwaita libreoffice

Actual results:
Distinct LibreOffice toolbar border

Expected results:
Less distinct LibreOffice toolbar border

Additional info:
- "Add style class to LibreOffice toolbars in gtk3"
  https://git.launchpad.net/~libreoffice/ubuntu/+source/libreoffice/tree/patches/gtk3-toolbar-styleclass.diff?h=ubuntu-yakkety-5.2
- "add style classes from LibreOffice toolbars (LP: 1580537)"
  https://bazaar.launchpad.net/~bjoern-michaelsen/ubuntu-themes/libreoffice-toolbars/revision/493
- "LibreOffice with ambiance theme and breeze icon style is unusable"
  https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1580537
- "Arc Darker: Display issues with LibreOffice GTK3 #659"
  https://github.com/horst3180/arc-theme/issues/659
- "LibreOffice toolbar borders #167"
  https://github.com/shimmerproject/Greybird/issues/167

Comment 1 Caolan McNamara 2017-01-10 15:56:00 UTC
I don't think any of those links leads to any proper solution though. Adding the style-class just provides a way to special-case things in themes for the libreoffice toolbar. The fundamental one was to theme it as a secondary toolbar under Ubuntu's default theme, because primary toolbars had a dark color by default, I dropped the "primary" toolbar setting by 5-3 so that's in rawhide already.

The "too-distinct" border is definitely still there in 5.3 though, clearly by comparison with glade which still has a toolbar for comparison purposes

Comment 2 Caolan McNamara 2017-01-11 10:20:27 UTC
k, found where that border was coming from, will be better in next update

Comment 3 poma 2017-01-12 10:48:36 UTC
(In reply to Caolan McNamara from comment #2)
> k, found where that border was coming from, will be better in next update

It's great as is straightforward, describing the actual use case.
Thanks!

Comment 4 poma 2017-01-12 10:49:54 UTC
Created attachment 1239849 [details]
Adwaita's surplus

Unlike other themes,
Adwaita draws a line under the menu bar.

Can it be tuned within the LO itself?

Comment 5 Caolan McNamara 2017-01-12 12:46:36 UTC
The line/border belongs to the menubar itself I believe. The menubar in LibreOffice is a truely native gtk3 menubar and not a libreoffice menubar themed to look like a gtk3 menubar, so its outside of our scope

Comment 6 poma 2017-01-14 18:41:38 UTC
(In reply to Caolan McNamara from comment #5)
> The line/border belongs to the menubar itself I believe. The menubar in
> LibreOffice is a truely native gtk3 menubar and not a libreoffice menubar
> themed to look like a gtk3 menubar, so its outside of our scope

Thanks for clarifying.
Removing the first appearance of 'box-shadow' property within the menubar section did the trick.

Comment 7 poma 2017-01-14 18:42:54 UTC
Created attachment 1240772 [details]
As a reminder.

Comment 8 Fedora Update System 2017-01-18 16:21:47 UTC
libreoffice-5.2.4.2-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20e8f680b

Comment 9 David H. Gutteridge 2017-01-18 19:47:31 UTC
This looks to me to indeed be addressed in libreoffice-5.2.4.2-3.fc25.

Comment 10 Fedora Update System 2017-01-19 09:12:12 UTC
libreoffice-5.2.4.2-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20e8f680b

Comment 11 Fedora Update System 2017-01-20 18:07:20 UTC
libreoffice-5.2.4.2-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.