Bug 1408666 - ksvalidator ignores hibernation option for logvol swap lines with more options
Summary: ksvalidator ignores hibernation option for logvol swap lines with more options
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pykickstart
Version: 25
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-26 09:53 UTC by Eric Lavarde
Modified: 2017-04-17 15:53 UTC (History)
2 users (show)

Fixed In Version: pykickstart-2.34-1 pykickstart-2.34-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-17 15:53:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Eric Lavarde 2016-12-26 09:53:50 UTC
Description of problem:
When I call ksvalidator on a kickstart file with a line like:

logvol swap --hibernation --name=Swap --vgname=RHEL7CSB --label=SWAPFS

it complains that:

The following problem occurred on line 56 of the kickstart file:

No size given for logical volume. Use one of --useexisting, --noformat, --size, or --percent.

Version-Release number of selected component (if applicable):
pykickstart-2.32-1.fc25.noarch

How reproducible:
Always

Steps to Reproduce:
1. create a kickstart with the above line
2. call ksvalidator on it

Actual results:
See above

Expected results:
No complain

Additional info:
- if I add --recommended to the line, pyvalidator stops complaining (shouldn't it actually complain that both options are mutually exclusive?)
- without _some of_ the additional parameters (name, vgname, label), it doesn't complain either, but it doesn't seem to be linked to a specific parameter, just to the number of them, as I only need to remove 1 or 2 of them, whichever.

Comment 1 Eric Lavarde 2016-12-29 14:59:39 UTC
The priority should be raised, I get the same error while using the kickstart file, meaning I can't install a PC with those options.

Comment 2 Chris Lumens 2017-01-11 18:53:01 UTC
Thanks for the report.  This should also be fixed in the next build of pykickstart, which will be coming along shortly.  I don't know about the additional parameters portion, but if you do find a bug there feel free to open up a new report and I'll take a look.

Comment 3 Fedora Update System 2017-04-16 23:21:19 UTC
pykickstart-2.34-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fa3fe5de83

Comment 4 Fedora Update System 2017-04-17 15:53:32 UTC
pykickstart-2.34-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.