Bug 1408790 - After hotplugging CPU results in frequent KeyError.
Summary: After hotplugging CPU results in frequent KeyError.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.6.9
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.1.0-beta
: ---
Assignee: Milan Zamazal
QA Contact: Israel Pinto
URL:
Whiteboard:
Depends On:
Blocks: 1413968 1413970
TreeView+ depends on / blocked
 
Reported: 2016-12-27 08:44 UTC by Ameya Charekar
Modified: 2021-03-11 15:29 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, there were frequent KeyError tracebacks in the vdsm.log after CPU hotplug. Now, these errors are no longer produced by VDSM after CPU hotplug.
Clone Of:
: 1413968 1413970 (view as bug list)
Environment:
Last Closed: 2017-04-25 00:42:22 UTC
oVirt Team: Virt
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2017:0997 0 normal SHIPPED_LIVE Red Hat Virtualization Manager (ovirt-engine) 4.1 GA 2017-04-18 20:11:26 UTC
oVirt gerrit 69999 0 None None None 2017-01-13 13:56:33 UTC
oVirt gerrit 70356 0 None None None 2017-01-13 13:57:13 UTC

Description Ameya Charekar 2016-12-27 08:44:51 UTC 
After hotplugging CPU results in following KeyError:

~~~
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/executor.py", line 192, in _execute_task
    callable()
  File "/usr/share/vdsm/virt/periodic.py", line 289, in __call__
    self._execute()
  File "/usr/share/vdsm/virt/periodic.py", line 345, in _execute
    self._vm.updateNumaInfo()
  File "/usr/share/vdsm/virt/vm.py", line 5181, in updateNumaInfo
    self._numaInfo = numaUtils.getVmNumaNodeRuntimeInfo(self)
  File "/usr/share/vdsm/numaUtils.py", line 116, in getVmNumaNodeRuntimeInfo
    vnode_index = str(vcpu_to_vnode[vcpu_id])
KeyError: 8
~~~

We already have upstream patch for the same:

https://gerrit.ovirt.org/#/c/65562/1..4

But latest Package - vdsm-python-4.18.15.3-1.el7ev.noarch.rpm does not have the patch.
Comment 1 Michal Skrivanek 2016-12-28 07:59:48 UTC 
Yes, this is fixed in 4.1. Is that enough or an earlier release is requested?
Comment 4 Milan Zamazal 2017-01-13 13:57:53 UTC 
Patch backported to 4.0, backport to 3.6 posted.
Comment 8 Israel Pinto 2017-01-24 09:54:49 UTC 
Verify with:
Engine Version: 4.1.0.3-0.0.master.20170123183440.gita89d24a.el7.centos
Host: 
OS Version:RHEL - 7.3 - 7.el7
Kernel Version:3.10.0 - 514.6.1.el7.x86_64
KVM Version:2.6.0 - 28.el7_3.3.1
LIBVIRT Version:libvirt-2.0.0-10.el7_3.4
VDSM Version:vdsm-4.19.2-6.gitd2cbe37.el7.centos
SPICE Version:0.12.4 - 20.el7_3

Steps:
1. Create VM with 1 CPU and Run it
2. Hotplug CPU to 2 and check vdsm log 
2. Hot unplug CPU to 1 and check vdsm log 

Results:
CPU is updated, No Error in vdms log
Note You need to log in before you can comment on or make changes to this bug.