Description of problem: https://github.com/openshift/origin/issues/6817 Version-Release number of selected component (if applicable): 3.3.0 How reproducible: 100% Steps to Reproduce: see https://github.com/openshift/origin/issues/6817 Actual results: OPENSHIFT_BUILD_COMMIT env var not set when build is triggered Expected results: OPENSHIFT_BUILD_COMMIT env is set when build is triggered Additional info:
Ben assigning to you, since you are assigned the origin issue
we should be adding the commit information in a consistent way: clone the git repo check out the requested commit/ref (if any, otherwise master) check what the current commit information is apply that commit information as labels/env/etc. i'm guessing this is currently broken because the ENV comes from the webhook info and the label comes from the flow I just described.
https://github.com/openshift/origin/pull/12390
Verified openshift v1.5.0-alpha.1+15872c0-61 kubernetes v1.4.0+776c994 etcd 3.1.0-rc.0 devenv-centos7_5644 (ami-8fc12599) docker build logs: Step 13 : ENV "OPENSHIFT_BUILD_NAME" "ruby-sample-build-1" "OPENSHIFT_BUILD_NAMESPACE" "dyan" "OPENSHIFT_BUILD_SOURCE" "git://github.com/openshift/ruby-hello-world.git" "OPENSHIFT_BUILD_COMMIT" "e79d8870be808a7abb4ab304e94c8bee69d909c6" ---> Running in a674847812b0 ---> a6fed1ff2c15 Removing intermediate container a674847812b0 docker build and sti build image $ env |grep OPENSHIFT OPENSHIFT_BUILD_COMMIT=e79d8870be808a7abb4ab304e94c8bee69d909c6 OPENSHIFT_BUILD_NAME=ruby-sample-build-1 OPENSHIFT_BUILD_SOURCE=https://github.com/openshift/ruby-hello-world.git OPENSHIFT_BUILD_NAMESPACE=dyan1 need verify on ocp once pr merged
This has been merged into ocp and is in OCP v3.5.0.7 or newer.
Verified openshift v3.5.0.7+390ef18 kubernetes v1.5.2+43a9be4 etcd 3.1.0-rc.0
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:0884