Bug 1409277 - Don't call brp-java-repack-jars from %scl_package
Summary: Don't call brp-java-repack-jars from %scl_package
Keywords:
Status: CLOSED DUPLICATE of bug 1431004
Alias: None
Product: Fedora
Classification: Fedora
Component: scl-utils
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-12-31 00:35 UTC by Pavel Raiskup
Modified: 2017-03-20 09:45 UTC (History)
4 users (show)

Fixed In Version: scl-utils-2.0.1-12.fc27
Clone Of:
Environment:
Last Closed: 2017-03-20 08:21:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed fix for rawhide (f26) (2.89 KB, application/mbox)
2017-02-17 06:15 UTC, Pavel Raiskup
no flags Details

Description Pavel Raiskup 2016-12-31 00:35:47 UTC
There's something like:

    /usr/lib/rpm/brp-scl-compress %{_scl_root}
    %{!?__debug_package:/usr/lib/rpm/brp-strip %{__strip}
    /usr/lib/rpm/brp-strip-comment-note %{__strip} %{__objdump}
    }
    /usr/lib/rpm/brp-strip-static-archive %{__strip}
    /usr/lib/rpm/brp-scl-python-bytecompile %{__python}
    %{?_python_bytecompile_errors_terminate_build} %{_scl_root}
    /usr/lib/rpm/brp-python-hardlink
    %{!?__jar_repack:/usr/lib/rpm/redhat/brp-java-repack-jars}

.. in scl-utils macros file.  But those brp-* tools are not in Rawhide
(F26+) and thus calling those non-existent scripts causes FTBFS.

Comment 1 Pavel Raiskup 2017-02-17 05:59:09 UTC
It looks like only one script causes issues, upstream proposal:
https://github.com/sclorg/scl-utils/pull/12/

Comment 2 Pavel Raiskup 2017-02-17 06:15:18 UTC
Created attachment 1251791 [details]
Proposed fix for rawhide (f26)

I tried to build scl-utils with this fix [1] and it fixed the issues for
me [2].  Thanks for considering.

https://copr.fedorainfracloud.org/coprs/praiskup/autotools/build/513033/
https://copr.fedorainfracloud.org/coprs/praiskup/autotools/build/513034/

Comment 3 Fedora End Of Life 2017-02-28 10:51:43 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 4 Panu Matilainen 2017-03-20 08:21:48 UTC
Fixed in rawhide, at least for now with the simpler approach of just dropping repack-jars entirely.

Comment 5 Pavel Raiskup 2017-03-20 09:10:36 UTC
Panu, thanks!

But fixing also F26 is crucial I would say.  Did you consider it?

Comment 6 Panu Matilainen 2017-03-20 09:13:54 UTC
F26 is tracked in bug 1431004 (an update has been submitted already)

Comment 7 Pavel Raiskup 2017-03-20 09:45:18 UTC

*** This bug has been marked as a duplicate of bug 1431004 ***


Note You need to log in before you can comment on or make changes to this bug.