Spec URL: https://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-clutter-gdk.spec SRPM URL: https://mtasaka.fedorapeople.org/Review_request/ruby-gnome2-suite/rubygem-clutter-gdk-3.1.0-1.fc.src.rpm Description: Ruby/ClutterGDK is a Ruby binding of GDK specific API of Clutter. Fedora Account System Username: mtasaka Koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17124568
In the list has been mentioned the cosmetic thing about ".freeze" - it is possible to use it always - without F26 test. But disabling it when not needed is fine too. Nice package. APPROVED! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2.1 or later)", "Unknown or generated". 3 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. Tested command: ruby -rclutter-gdk -e 's=Clutter::Stage.new; s.show; p s.gdk_window' Prints: #<#<Class:0x00559d757081c8>:0x559d75708100 ptr=0x559d74f5b4b0> [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: gems should not require rubygems package [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-clutter-gdk-3.1.0-1.fc26.noarch.rpm rubygem-clutter-gdk-doc-3.1.0-1.fc26.noarch.rpm rubygem-clutter-gdk-3.1.0-1.fc26.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- rubygem-clutter-gdk (rpmlib, GLIBC filtered): clutter-gtk ruby(rubygems) rubygem(clutter) rubygem(gdk3) rubygem-clutter-gdk-doc (rpmlib, GLIBC filtered): rubygem-clutter-gdk Provides -------- rubygem-clutter-gdk: rubygem(clutter-gdk) rubygem-clutter-gdk rubygem-clutter-gdk-doc: rubygem-clutter-gdk-doc Source checksums ---------------- https://raw.githubusercontent.com/ruby-gnome2/ruby-gnome2/master/clutter-gdk/README.md : CHECKSUM(SHA256) this package : 7c18cd2116f2c233b1d22023b07dd2e8e890b73a71483e67bde7e55636ba4d64 CHECKSUM(SHA256) upstream package : 7c18cd2116f2c233b1d22023b07dd2e8e890b73a71483e67bde7e55636ba4d64 https://rubygems.org/gems/clutter-gdk-3.1.0.gem : CHECKSUM(SHA256) this package : 2b4b7d632846c5d3906b2c630da589e9a13e9b1e6762511ba18cfd26deaf6a39 CHECKSUM(SHA256) upstream package : 2b4b7d632846c5d3906b2c630da589e9a13e9b1e6762511ba18cfd26deaf6a39 https://raw.githubusercontent.com/ruby-gnome2/ruby-gnome2/master/clutter-gdk/COPYING.LIB : CHECKSUM(SHA256) this package : dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 CHECKSUM(SHA256) upstream package : dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1409288 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thank you for review!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-clutter-gdk
This is already in repository, closing. Thank you for review!