Created attachment 1237268 [details] Patch Attached patch fixes build against sip-4.19: https://koji.fedoraproject.org/koji/taskinfo?taskID=17163962
(In reply to Sandro Mani from comment #0) > > Attached patch fixes build against sip-4.19: > > https://koji.fedoraproject.org/koji/taskinfo?taskID=17163962 Thanks, Sandro! I've applied the patch (along with some other spec updates) and pushed it to rawhide: https://src.fedoraproject.org/cgit/rpms/PyQwt.git/commit/?id=974991cfedfa7973fb1349b47e28632741ae1996 https://koji.fedoraproject.org/koji/taskinfo?taskID=17233603
That's an odd patch, much of it includes removal of stanzas like: #if SIP_VERSION < 0x040800 ... which should not be evaluating to true in this context. Any idea(s) why that is? (ie, I'd rather fix the version comparison logic rather than working-around it)
that said, we (and PyQwt upstream) probably have little to no interest maintaining compatibility for such old sip versions
@Rex: The codebase was half-ported to newer SIP verison, i.e. where the #if SIP_VERSION < 0x040800 appeared. To make it easier to grep through the codebase to ensure I ported everything, I removed the code for the old SIP versions.