Description of problem: I guess this is likely really a pyrpkg bug... `fedpkg local` seems to return 0 (success) even when the build fails. Version-Release number of selected component (if applicable): fedpkg-1.26-4.fc26 rpkg-1.48-1.fc26 Steps to Reproduce: 0. edit pkg spec file locally so that it fails 1. run `fedpkg local` Actual results: 1. exitcode 0 Expected results: 1. exitcode > 0 Additional info: Regression? I /think/ this was not happening earlier?
`fedpkg local` runs this rpmbuild rpmbuild --define '_sourcedir /root/packages/patchutils' ... -ba /root/packages/patchutils/patchutils.spec | tee .build-0.3.4-5.fc26.log It returns 0 even if rpmbuild fails, then it cause fedpkg returns 0. I think it makes sense to return non-zero if rpmbuild fails.
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
(In reply to cqi from comment #1) > `fedpkg local` runs this rpmbuild > > rpmbuild --define '_sourcedir /root/packages/patchutils' ... -ba > /root/packages/patchutils/patchutils.spec | tee .build-0.3.4-5.fc26.log > > It returns 0 even if rpmbuild fails, then it cause fedpkg returns 0. I think rpmbuild returns non-zero if it fails so is it due to the pipe?
(In reply to Jens Petersen from comment #3) > (In reply to cqi from comment #1) > > `fedpkg local` runs this rpmbuild > > > > rpmbuild --define '_sourcedir /root/packages/patchutils' ... -ba > > /root/packages/patchutils/patchutils.spec | tee .build-0.3.4-5.fc26.log > > > > It returns 0 even if rpmbuild fails, then it cause fedpkg returns 0. > > I think rpmbuild returns non-zero if it fails so is it due to the pipe? I think so.
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle. Changing version to '26'.
PR https://pagure.io/rpkg/pull-request/228 is proposed. Not sure it is a good way to fix this problem. Waiting for review.
PR#228 has been merged.
fedpkg-1.29-1.fc26 rpkg-1.50-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-fd4f4928b7
fedpkg-1.29-1.el6, rpkg-1.50-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1c685ce277
fedpkg-1.29-1.el7, rpkg-1.50-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c5c94bf8c
fedpkg-1.29-1.fc25, rpkg-1.50-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0d9aff598
fedpkg-1.29-1.fc26, rpkg-1.50-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-fd4f4928b7
fedpkg-1.29-1.fc26, rpkg-1.50-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
fedpkg-1.29-2.fc25 rpkg-1.50-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0d9aff598
fedpkg-1.29-2.el6 rpkg-1.50-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1c685ce277
fedpkg-1.29-2.el7 rpkg-1.50-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c5c94bf8c
fedpkg-1.29-2.fc25, rpkg-1.50-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0d9aff598
fedpkg-1.29-2.el6, rpkg-1.50-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1c685ce277
fedpkg-1.29-2.el7, rpkg-1.50-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c5c94bf8c
fedpkg-1.29-3.fc25 rpkg-1.50-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0d9aff598
fedpkg-1.29-3.el6 rpkg-1.50-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1c685ce277
fedpkg-1.29-3.el7 rpkg-1.50-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c5c94bf8c
fedpkg-1.29-3.fc27 rpkg-1.50-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8bb22880f0
fedpkg-1.29-3.el6, rpkg-1.50-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1c685ce277
fedpkg-1.29-3.el7, rpkg-1.50-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2c5c94bf8c
fedpkg-1.29-3.fc25, rpkg-1.50-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f0d9aff598
fedpkg-1.29-3.fc27, rpkg-1.50-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8bb22880f0
fedpkg-1.29-3.fc27, rpkg-1.50-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
fedpkg-1.29-3.fc25, rpkg-1.50-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
fedpkg-1.29-3.el6, rpkg-1.50-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
fedpkg-1.29-3.el7, rpkg-1.50-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.