Bug 1410490 - [RFE] Do not check VLAN ID for duplicates (allow them on different networks, DCs... ?)
Summary: [RFE] Do not check VLAN ID for duplicates (allow them on different networks, ...
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.6.9
Hardware: All
OS: Linux
Target Milestone: ovirt-4.2.0
: ---
Assignee: Leon Goldberg
QA Contact: Michael Burman
Depends On: 1319323
Blocks: 1467058
TreeView+ depends on / blocked
Reported: 2017-01-05 15:36 UTC by vaibhav
Modified: 2020-09-10 10:05 UTC (History)
13 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 1319323
: 1467058 (view as bug list)
Last Closed: 2018-05-15 17:40:52 UTC
oVirt Team: Network
Target Upstream Version:
gklein: testing_plan_complete+

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2018:1488 0 None None None 2018-05-15 17:42:08 UTC
oVirt gerrit 57571 0 None ABANDONED engine: remove VLAN_ID uniqueness across DC networks validation 2020-05-14 10:32:05 UTC
oVirt gerrit 78303 0 master MERGED backend: don't check for duplicate vlan ids 2020-05-14 10:32:06 UTC
oVirt gerrit 78887 0 ovirt-engine-4.1 MERGED backend: don't check for duplicate vlan ids 2020-05-14 10:32:05 UTC
oVirt gerrit 78888 0 ovirt-engine-4.1 MERGED frontend: disallow duplicate vlan ids on a single interface 2020-05-14 10:32:05 UTC

Description vaibhav 2017-01-05 15:36:34 UTC
+++ This bug was initially created as a clone of Bug #1319323 +++

Description of problem:
Adding new network with vlan tag, ovirt doesn't allow duplicate VLAN IDs.
But it should be allowed, because if you are using multiple interfaces you can have the same vlan ID as long as they aren't assigned to the same interface on the hardware node.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Just add network with same vlan id as an already added interface.


Actual results:
See email thread labeled "Re: [ovirt-users] multiple NICs VLAN ID conflict".
GUI says vlan already used.

Expected results:
Duplicate VLAN ID should be checked when you are assign network to the hardware node, not when creating the interface.

Additional info:
Trying to work around this with vdsm hooks in before_network_setup, after_get_caps and after_get_stats is very difficult to get it to work right. (see email thread)

--- Additional comment from Yaniv Kaul on 2016-03-20 03:12:24 EDT ---

Perhaps only WARN.

--- Additional comment from bill.james on 2016-03-23 17:21:38 EDT ---

(In reply to Yaniv Kaul from comment #1)
> Perhaps only WARN.

Just warning at network creation time would be fine too.

--- Additional comment from bill.james on 2016-03-30 12:31:59 EDT ---

Any chance I could get a "patch" or "hack" that could change the rejection to a warning?
Unfortunately this is holding up me being able to deploy oVirt.


--- Additional comment from Dan Kenigsberg on 2016-05-17 10:47:40 EDT ---

I'm afraid that we should fix Engine to accept this. Yevgeni, how hard is the fix?

Bill, can you add a reference to the email thread? I'd like to understand which problem you have seen with implementing this with a vdsm hook.

--- Additional comment from Yevgeny Zaspitsky on 2016-05-17 11:22:18 EDT ---

The change on the engine side for the "add network" flow seems quite easy to me.
However it might break some decisions that were made based on the assumption that VLAN_ID is unique across a DC networks.

Bill, could you please explain the use-case where multiple networks could bear the same VLAN_ID in a single data-center?

--- Additional comment from bill.james on 2016-05-17 11:34:56 EDT ---

We have 4 different switches in our prod datacenter that cover different products and usage requirements. We want to keep some products separate from others which is why they have their own switch and set of subnets.
Since they are separate switches there was no need to be concerned about keeping VLAN IDs unique across switches.
With virtualization we don't mind mixing products on same hardware, but want to keep network traffic separated. So our hardware nodes have 8 NICs to handle all the different network switches. Our previous virtualization platform didn't have any problem with duplicate VLAN IDs so this wasn't an issue. Until we tried to move to oVirt.

--- Additional comment from Yevgeny Zaspitsky on 2016-05-17 12:30:36 EDT ---


I've created the Gerrit patch [1] that removes the validation.
Please let us know if you're able to consume the patch (build oVirt from its sources) and if the patch does what you ask for.

[1] http://gerrit.ovirt.org/57571

--- Additional comment from Dan Kenigsberg on 2016-05-18 08:30:37 EDT ---

The request was discussed on http://lists.ovirt.org/pipermail/users/2016-March/038463.html

--- Additional comment from bill.james on 2016-06-13 11:33:56 EDT ---

sorry, I haven't had a chance to setup a build host for ovirt yet so haven't tested the patch.

Comment 7 Dan Kenigsberg 2017-02-14 06:26:18 UTC
Would you be willing to try out an upstream build with the suggested patch, to help in testing it?

Comment 18 Michael Burman 2017-11-21 07:44:13 UTC
Verified on - 4.2.0-0.5.master.el7

Comment 21 errata-xmlrpc 2018-05-15 17:40:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Comment 22 Franta Kust 2019-05-16 13:05:01 UTC
BZ<2>Jira Resync

Note You need to log in before you can comment on or make changes to this bug.