Bug 1411170 - Network Router provisioning must call and use raw create method
Summary: Network Router provisioning must call and use raw create method
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.8.0
Hardware: Unspecified
OS: Unspecified
Target Milestone: GA
: 5.8.0
Assignee: Gilles Dubreuil
QA Contact: Omri Hochman
Depends On:
Blocks: 1413677
TreeView+ depends on / blocked
Reported: 2017-01-08 23:55 UTC by Gilles Dubreuil
Modified: 2018-06-15 13:56 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1413677 (view as bug list)
Last Closed: 2017-06-12 16:35:59 UTC
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:

Attachments (Terms of Use)

Description Gilles Dubreuil 2017-01-08 23:55:56 UTC
In https://github.com/ManageIQ/manageiq/pull/12045 the call to  'create_network_router' replaces 'raw_create_network_router' but the method name itself wasn't  replaced. This wasn't meant for this PR. So when PR#12045 is backported to euwe then https://github.com/ManageIQ/manageiq/pull/13072 Pull Request which takes care of the method renaming must be backported too.

Comment 3 Gilles Dubreuil 2017-01-10 03:41:07 UTC
https://github.com/ManageIQ/manageiq/pull/13072 has been merged on master branch.
Since this issue doesn't apply to euwe (5.7.1) we can close it.

Comment 4 Tzu-Mainn Chen 2017-01-16 14:36:12 UTC
Gilles, just to double-check - are you saying we don't need https://github.com/ManageIQ/manageiq/pull/13072 and https://github.com/ManageIQ/manageiq/pull/13462 in Euwe after all?

Comment 5 Tzu-Mainn Chen 2017-01-16 16:12:46 UTC
After further checking, this is needed for https://bugzilla.redhat.com/show_bug.cgi?id=1394284; moving to POST

Comment 7 Gilles Dubreuil 2017-02-14 04:46:10 UTC
Sorry for late reply, that one slipped out of sight.

To me it seems one of the backport overlapped, anyway it doesn't matter as now all the raw calls are wrapped.


Comment 8 Ronnie Rasouli 2017-03-08 13:12:00 UTC
verified on
created and delete router

Note You need to log in before you can comment on or make changes to this bug.