Spec URL: https://svn.calcforge.org/viewvc/*checkout*/kannolo/trunk/packages/ufw-kde/ufw-kde.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kkofler/kannolo/fedora-26-x86_64/00461614-ufw-kde/ufw-kde-0.5.0-0.3.20161006git.fc26.src.rpm Description: KDE KControl Module to configure and control the Uncomplicated Firewall (UFW). Fedora Account System Username: kkofler
Taking this review.
Ping? While I'm not in a rush to get this package into Fedora proper (I have it in my Kannolo Copr), it would still be useful to get this off my todo list at some point.
Review notes: + Generally complies with packaging guidelines + Package is named appropriately + Consistently uses macros ! /usr/bin/env is a requirement ! rpmlint error: - ufw-kde.x86_64: E: wrong-script-interpreter /usr/libexec/kde4/kcm_ufw_helper.py /usr/bin/env python3 The wrong-script-interpreter error is also likely leading to /usr/bin/env being a requirement when it shouldn't be.
Meh, I still don't see what's so bad about using /usr/bin/env, but I can fix that, it should be a one-line patch. Anything else I should fix while I am at it?
(In reply to Kevin Kofler from comment #4) > Meh, I still don't see what's so bad about using /usr/bin/env, but I can fix > that, it should be a one-line patch. > > Anything else I should fix while I am at it? At the moment, I don't see anything else.
Spec URL: https://svn.calcforge.org/viewvc/*checkout*/kannolo/trunk/packages/ufw-kde/ufw-kde.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/kkofler/kannolo/fedora-26-x86_64/00507752-ufw-kde/ufw-kde-0.5.0-0.4.20161006git.fc26.src.rpm * Sun Feb 05 2017 Kevin Kofler <Kevin.org> - 0.5.0-0.4.20161006git - Do not use #!/usr/bin/env for the Python helper I used this patch: https://svn.calcforge.org/viewvc/kannolo/trunk/packages/ufw-kde/ufw-kde-0.5.0-no-env.patch?revision=263&view=markup
Excellent, looks good to me. PACKAGE APPROVED.
Thanks, package requested in pkgdb.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ufw-kde
ufw-kde-0.5.0-0.5.20161006git.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a3ec4299a
ufw-kde-0.5.0-0.5.20161006git.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f4305beb2
ufw-kde-0.5.0-0.5.20161006git.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-7f4305beb2
ufw-kde-0.5.0-0.5.20161006git.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-2a3ec4299a
ufw-kde-0.5.0-0.5.20161006git.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
ufw-kde-0.5.0-0.5.20161006git.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.