Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1412628 - FTBFS: Ruby 2.4 compatibility
Summary: FTBFS: Ruby 2.4 compatibility
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-activesupport
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-12 13:47 UTC by Jun Aruga
Modified: 2017-01-12 14:17 UTC (History)
6 users (show)

Fixed In Version: rubygem-activesupport-5.0.1-2.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-12 14:17:12 UTC
Type: Bug


Attachments (Terms of Use)
Patch for Ruby 2.4.0 compatibility (14.04 KB, patch)
2017-01-12 13:47 UTC, Jun Aruga
no flags Details | Diff

Description Jun Aruga 2017-01-12 13:47:08 UTC
Created attachment 1239938 [details]
Patch for Ruby 2.4.0 compatibility

Description of problem:

Build failure for target Ruby 2.4.

Version-Release number of selected component (if applicable):
rubygem-activesupport-5.0.1-1.fc26

How reproducible:


Steps to Reproduce:

$ fedpkg scratch-build --srpm --target f26-ruby24
https://koji.fedoraproject.org/koji/taskinfo?taskID=17255100

Actual results:
Build failed.
> 3371 runs, 10164 assertions, 2 failures, 1 errors, 222 skips

Expected results:
Build success

Additional info:

I uploaded a patch to fix it.
Build is success for both current rawhide (Ruby 2.3) and Ruby 2.4.

Scratch build URL (Target: Ruby 2.4):
$ fedpkg scratch-build --srpm --target f26-ruby24
https://koji.fedoraproject.org/koji/taskinfo?taskID=17256490

I checked below things.

- license check: ok
- rpmlint: ok
But please take note existed way to patch: `patch -p2 < %{PATCH4}` is not detected by rpmlint.
So, I used another way for this kind of case for my patches.
./rubygem-activesupport.spec: W: patch-not-applied Patch4: rubygem-activesupport-5.0.1-Fixnum-and-Bignum-are-deprecated-in-Ruby-trunk-tests.patch

- install: ok (I tried it to only current rawhide mock environment.)

Comment 1 Vít Ondruch 2017-01-12 14:17:12 UTC
Thank you Jun. I applied the patch and build the package in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.