Hide Forgot
Spec URL: https://bowlofeggs.fedorapeople.org/php-evenement.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-evenement-2.0.0-1.fc26.src.rpm Description: Événement is a very simple event dispatching library for PHP. It has the same design goals as Silex and Pimple, to empower the user while staying concise and simple. It is very strongly inspired by the EventEmitter API found in node.js. Autoloader: %{_datadir}/php/Evenement/Evenement/autoload.php Fedora Account System Username: bowlofeggs
Can you please apply changes proposed by Shawn on ML so I will be able to review this package which blocks some other review. https://github.com/siwinski/rpms/commit/6a742706850fdae41724b97622c84146a7d86ae5
Sure, here they are: Spec URL: https://bowlofeggs.fedorapeople.org/php-evenement.spec SRPM URL: https://bowlofeggs.fedorapeople.org/php-evenement-2.0.0-2.fc26.src.rpm Thanks so much for the patch Shawn!
Created attachment 1243082 [details] phpci.log phpCompatInfo version 5.0.4 DB version 1.16.0 built Dec 16 2016 06:59:17 CET static analyze results
Created attachment 1243083 [details] review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1413339 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api
Created attachment 1243084 [details] 0000-Fix-a-test-to-catch-TypeError-instead-of-Exception.patch Improved patch for PHP 5 and 7
[~]: %check is present and all tests pass. OK with 7.0 and 7.1 KO with 5.6 Not a blocker (review is for rawhide which have PHP 7.1), but please consider updating the patch (and your PR). [x]: Package complies to the Packaging Guidelines So, APPROVED P.S. I hate github URL using not reliable "tag", and prefer "commit"... but Guidelines mostly say "do the fuck you want"... so ...
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-evenement
php-evenement-2.0.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-2bdd80ab7b
php-evenement-2.0.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-62f41a1300
php-evenement-2.0.0-3.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8b991469c5
Release 3 has Remi's patch so it will work on PHP 5 (F24) and PHP 7 (F25, F26). Thanks for the patch Remi!
php-evenement-2.0.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-62f41a1300
php-evenement-2.0.0-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8b991469c5
php-evenement-2.0.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
php-evenement-2.0.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.