Bug 1413367 - Missing validation on register node, action fired with success falsely
Summary: Missing validation on register node, action fired with success falsely
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Providers
Version: 5.7.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: cfme-future
Assignee: Marek Aufart
QA Contact: Omri Hochman
URL:
Whiteboard: openstack:infra
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-15 12:29 UTC by Ronnie Rasouli
Modified: 2018-10-02 14:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Category: ---
Cloudforms Team: Openstack
Target Upstream Version:


Attachments (Terms of Use)

Description Ronnie Rasouli 2017-01-15 12:29:55 UTC
Description of problem:

On node registration there isn't any pre submit validation.
In addition, the action sent successfully while on RHOS it fails.

In my case I tried to add my_file.json.reg to node registration, the action show success but no new node added to ironic-node list

if I try to add the same file on ironic it fails.

$ openstack baremetal import my_file.json.reg 
Invalid file extension for my_file.json.reg, must be json, yaml or csv

In case the import will include json extension it will pass

Further more, in case there is a wrong parameter (for example json file that contains existing name), as above the import will fail on Ironic, pass on UI

Version-Release number of selected component (if applicable):
5.7.0.17

How reproducible:
100%

Steps to Reproduce:
see description

Actual results:

import (node register) pass

Expected results:

Fail the action:

1. fail in case the file extension is not json
2. sync with errors returns from OSP


Additional info:

Comment 3 Josh Carter 2018-10-02 14:33:00 UTC
Dear customer, 

The CloudForms team is reviewing the current CloudForms Bug(defect) backlog in order to target engineering efforts. We are closing any bugs for versions that no longer have an active errata stream or that have hit their age limit. We are committing to better management of the backlog as we move forward. If you have an bug that you are still able to reproduce on a current version of CloudForms please open a new bug. 

If you have any concerns about this, please let us know.

Thanks and regards!

Comment 4 Josh Carter 2018-10-02 14:33:49 UTC
Dear customer, 

The CloudForms team is reviewing the current CloudForms Bug(defect) backlog in order to target engineering efforts. We are closing any bugs for versions that no longer have an active errata stream or that have hit their age limit. We are committing to better management of the backlog as we move forward. If you have an bug that you are still able to reproduce on a current version of CloudForms please open a new bug. 

If you have any concerns about this, please let us know.

Thanks and regards!

Comment 5 Josh Carter 2018-10-02 14:35:13 UTC
Dear customer, 

The CloudForms team is reviewing the current CloudForms Bug(defect) backlog in order to target engineering efforts. We are closing any bugs for versions that no longer have an active errata stream or that have hit their age limit. We are committing to better management of the backlog as we move forward. If you have an bug that you are still able to reproduce on a current version of CloudForms please open a new bug. 

If you have any concerns about this, please let us know.

Thanks and regards!


Note You need to log in before you can comment on or make changes to this bug.