Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/knotes.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/knotes-16.12.1-1.fc25.src.rpm Description: Popup Notes Fedora Account System Username: rdieter
required kde-apps-16.12 dependencies are building now for rawhide. Once in, I'll submit a scratch build.
Requires: %{name}-libs%%{?_isa} = %{version}-%{release} That should be "Requires: %{name}-libs%{?_isa} = %{version}-%{release}", otherwise isa macro is not evaluated and the packages do not install ;)
Approved, you should think about adding Requires: hicolor-icon-theme (directory ownership) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ==> Unversioned files are plugins => fine [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL", "GPL (v2 or later)", "Unknown or generated", "*No copyright* BSD (3 clause)", "LGPL (v2 or later)", "GPL (v2 or later) (with Qt exception)". 11 files have unknown license. Detailed output of licensecheck in /home/review/1414030-knotes/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/kservices5/kontact, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/64x64, /usr/share/kontact/ksettingsdialog, /usr/share/icons/hicolor/16x16/actions, /usr/share/dbus-1/interfaces, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor, /usr/share/kontact, /usr/share/dbus-1, /usr/share/config.kcfg, /usr/share/icons/hicolor/128x128, /usr/share/doc/HTML, /usr/share/icons/hicolor/32x32, /usr/share/doc/HTML/en, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/48x48, /usr/share/kxmlgui5 [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/doc/HTML/en/akonadi_notes_agent(kmail) ===> This is fallout from a change in packaging, old kmail subpackage will vanish and replaced by new one (16.12.x) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in knotes [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. ===> qt5-qtwebengine forces ExclusiveArch: %{qt5_qtwebengine_arches} which is included in spec [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knotes- libs , knotes-debuginfo [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. ===> qt5-qtwebengine forces ExclusiveArch: %{qt5_qtwebengine_arches} which is included in spec [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: knotes-16.12.1-1.fc26.x86_64.rpm knotes-libs-16.12.1-1.fc26.x86_64.rpm knotes-debuginfo-16.12.1-1.fc26.x86_64.rpm knotes-16.12.1-1.fc26.src.rpm knotes.x86_64: W: spelling-error Summary(en_US) Popup -> Po pup, Po-pup, Pop up knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes.categories knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes.renamecategories knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes_printing_theme.knsrc knotes.x86_64: W: no-manual-page-for-binary knotes knotes.x86_64: W: no-manual-page-for-binary akonadi_notes_agent knotes-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment knotes-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment knotes-libs.x86_64: W: no-documentation knotes.src: W: spelling-error Summary(en_US) Popup -> Po pup, Po-pup, Pop up 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: knotes-debuginfo-16.12.1-1.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory knotes-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment knotes-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5NewStuffCore.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5AkonadiContact.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libGrantlee_Templates.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5Contacts.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5SonnetUi.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5Attica.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5KIOCore.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5Service.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5Auth.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libKF5Codecs.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libQt5Xml.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libQt5Network.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libknotesprivate.so.5.4.1 /lib64/libm.so.6 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5AkonadiContact.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5Contacts.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5ItemModels.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5KIOCore.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5Service.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5Auth.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libKF5Codecs.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libQt5Xml.so.5 knotes-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libnotesharedprivate.so.5.4.1 /lib64/libm.so.6 knotes-libs.x86_64: W: no-documentation knotes.x86_64: W: spelling-error Summary(en_US) Popup -> Po pup, Po-pup, Pop up knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes.categories knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes.renamecategories knotes.x86_64: W: non-conffile-in-etc /etc/xdg/knotes_printing_theme.knsrc knotes.x86_64: W: no-manual-page-for-binary akonadi_notes_agent knotes.x86_64: W: no-manual-page-for-binary knotes 3 packages and 0 specfiles checked; 0 errors, 31 warnings. Requires -------- knotes-libs (rpmlib, GLIBC filtered): /sbin/ldconfig knotes libGrantlee_Templates.so.5()(64bit) libKF5AkonadiContact.so.5()(64bit) libKF5AkonadiCore.so.5()(64bit) libKF5AkonadiNotes.so.5()(64bit) libKF5AkonadiSearchPIM.so.5()(64bit) libKF5AkonadiWidgets.so.5()(64bit) libKF5Attica.so.5()(64bit) libKF5Auth.so.5()(64bit) libKF5Bookmarks.so.5()(64bit) libKF5CalendarCore.so.5()(64bit) libKF5CalendarUtils.so.5()(64bit) libKF5Codecs.so.5()(64bit) libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5Contacts.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5DNSSD.so.5()(64bit) libKF5GuiAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5IconThemes.so.5()(64bit) libKF5ItemModels.so.5()(64bit) libKF5ItemViews.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KCMUtils.so.5()(64bit) libKF5KDELibs4Support.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOFileWidgets.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5KontactInterface.so.5()(64bit) libKF5Libkdepim.so.5()(64bit) libKF5Mime.so.5()(64bit) libKF5NewStuff.so.5()(64bit) libKF5NewStuffCore.so.5()(64bit) libKF5Notifications.so.5()(64bit) libKF5Parts.so.5()(64bit) libKF5PimCommon.so.5()(64bit) libKF5PimTextEdit.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5Solid.so.5()(64bit) libKF5SonnetUi.so.5()(64bit) libKF5TextWidgets.so.5()(64bit) libKF5UnitConversion.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libical.so.2()(64bit) libicalss.so.2()(64bit) libknotesprivate.so.5()(64bit) libm.so.6()(64bit) libnotesharedprivate.so.5()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) knotes-debuginfo (rpmlib, GLIBC filtered): knotes (rpmlib, GLIBC filtered): /bin/sh knotes-libs(x86-64) libKF5AkonadiAgentBase.so.5()(64bit) libKF5AkonadiContact.so.5()(64bit) libKF5AkonadiCore.so.5()(64bit) libKF5AkonadiNotes.so.5()(64bit) libKF5AkonadiSearchDebug.so.5()(64bit) libKF5AkonadiWidgets.so.5()(64bit) libKF5Auth.so.5()(64bit) libKF5Bookmarks.so.5()(64bit) libKF5Codecs.so.5()(64bit) libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5Contacts.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5DNSSD.so.5()(64bit) libKF5GlobalAccel.so.5()(64bit) libKF5GuiAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5IconThemes.so.5()(64bit) libKF5ItemModels.so.5()(64bit) libKF5ItemViews.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KCMUtils.so.5()(64bit) libKF5KDELibs4Support.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOFileWidgets.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5KontactInterface.so.5()(64bit) libKF5Mime.so.5()(64bit) libKF5Notifications.so.5()(64bit) libKF5NotifyConfig.so.5()(64bit) libKF5Parts.so.5()(64bit) libKF5PimCommon.so.5()(64bit) libKF5PimTextEdit.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5Solid.so.5()(64bit) libKF5SonnetUi.so.5()(64bit) libKF5TextWidgets.so.5()(64bit) libKF5UnitConversion.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5X11Extras.so.5()(64bit) libQt5X11Extras.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libknotesprivate.so.5()(64bit) libm.so.6()(64bit) libnotesharedprivate.so.5()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- knotes-libs: knotes-libs knotes-libs(x86-64) libknotesprivate.so.5()(64bit) libnotesharedprivate.so.5()(64bit) knotes-debuginfo: knotes-debuginfo knotes-debuginfo(x86-64) knotes: appdata() appdata(org.kde.knotes.appdata.xml) application() application(org.kde.knotes.desktop) knotes knotes(x86-64) Unversioned so-files -------------------- knotes-libs: /usr/lib64/qt5/plugins/kcm_knote.so knotes-libs: /usr/lib64/qt5/plugins/kcm_knotessummary.so knotes-libs: /usr/lib64/qt5/plugins/kontact_knotesplugin.so Source checksums ---------------- http://download.kde.org/stable/applications/16.12.1/src/knotes-16.12.1.tar.xz : CHECKSUM(SHA256) this package : c88a0c8c368b8acd93cee14f448ed670747121d43a2e233ac988d1885d461a45 CHECKSUM(SHA256) upstream package : c88a0c8c368b8acd93cee14f448ed670747121d43a2e233ac988d1885d461a45 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1414030 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/knotes
imported, thanks.