Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1414404

Summary: virt-xml-validate fail to validate interface xml
Product: Red Hat Enterprise Linux 7 Reporter: yalzhang <yalzhang>
Component: libvirtAssignee: Laine Stump <laine>
Status: CLOSED ERRATA QA Contact: chhu
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.3CC: jdenemar, rbalakri, xuzhang
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-3.2.0-1.el7.x86_64 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1436300 (view as bug list) Environment:
Last Closed: 2017-08-01 17:21:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description yalzhang@redhat.com 2017-01-18 12:30:35 UTC
Description of problem:
virt-xml-validate fail to validate interface xml

Version-Release number of selected component (if applicable):
# rpm -q libvirt netcf
libvirt-2.5.0-1.el7.x86_64
netcf-0.2.8-2.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. dump the xml file of the existing physical interface;
# virsh iface-dumpxml enp0s25
<interface type='ethernet' name='enp0s25'>
  <protocol family='ipv4'>
    <ip address='10.66.5.0' prefix='22'/>
  </protocol>
  <protocol family='ipv6'>
    <ip address='fe80::1e6f:65ff:fe06:bc81' prefix='64'/>
  </protocol>
  <link speed='1000' state='up'/>
  <mac address='1c:6f:65:06:bc:81'/>
</interface>

# virsh iface-dumpxml enp0s25 > net

2. virt-xml-validate failed to validate the xml file
# virt-xml-validate net
net:1: element interface: Relax-NG validity error : Expecting an element start, got nothing
net:1: element interface: Relax-NG validity error : Invalid sequence in interleave
net:1: element interface: Relax-NG validity error : Element interface failed to validate content
net fails to validate

Actual results:
virt-xml-validate fail to validate file dumped by iface-dumpxml 

Expected results:
virt-xml-validate should successfully validate the file dumped by iface-dumpxml

Additional info:
Edit the physical interface by "virsh iface-edit" will not do the validation(no error pop up).
# virsh iface-edit enp0s25
Interface enp0s25 XML configuration edited.
I think "iface-edit" should do the validation because the xml has been edited.

Comment 1 Jaroslav Suchanek 2017-01-19 10:32:43 UTC
Is this for netcf component or not? In any case, seems like the validation is
expecting some <start mode='xx'/> element.

Comment 2 Laine Stump 2017-01-19 18:09:06 UTC
There are RNG files in both libvirt and netcf. In this case it's the copy in libvirt, but the two should match.

I believe there are some missing <interleave> elements in the interface RNG

Comment 3 Laine Stump 2017-03-27 04:56:24 UTC
Actually it was much simpler than that - the <start> element should be optional but it isn't. I've sent patches upstream to both libvirt and netcf to remedy this:

https://www.redhat.com/archives/libvir-list/2017-March/msg01262.html

https://lists.fedorahosted.org/archives/list/netcf-devel@lists.fedorahosted.org/thread/OCLPQ2WBSH7NPCHTYSWTCIVQ6QVWAUIR/

Comment 4 yalzhang@redhat.com 2017-04-06 13:51:03 UTC
verified on libvirt-3.2.0-1.el7.x86_64, the result is as expected.

1. 
# cat -n /usr/share/libvirt/schemas/interface.rng
..
281   <define name="startmode">
282     <optional>
283       <element name="start">
284         <attribute name="mode">
285           <choice>
286             <value>onboot</value>
287             <value>none</value>
288             <value>hotplug</value>
289             <!-- Jim Fehlig lists the following that SuSe supports:
290                  manual, ifplug, nfsroot -->
291           </choice>
292         </attribute>
293       </element>
294     </optional>
295   </define>
...

2. 
# virsh iface-list --all
 Name                 State      MAC Address
---------------------------------------------------
 enp0s25              active     1c:6f:65:06:bc:81
 eth0                 inactive   
 lo                   active     00:00:00:00:00:00
# virsh iface-dumpxml enp0s25 > /tmp/net
# virt-xml-validate /tmp/net
/tmp/net validates

Comment 5 errata-xmlrpc 2017-08-01 17:21:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846

Comment 6 errata-xmlrpc 2017-08-02 00:01:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:1846