Bug 1414964 - rpmlint fails to download sources for youtube-dl but it works with spectool -g
Summary: rpmlint fails to download sources for youtube-dl but it works with spectool -g
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: rpmlint
Version: 26
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tom "spot" Callaway
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-19 20:17 UTC by Till Maas
Modified: 2017-08-31 20:19 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-08-31 17:26:02 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Till Maas 2017-01-19 20:17:25 UTC
Description of problem:
According to https://taskotron.fedoraproject.org/artifacts/all/9f0aba22-d91c-11e6-9d1c-525400120b80/task_output/youtube-dl-2017.01.10-1.fc25.log the rpmlint check failed to download the sources due to a 403 error but it works here. Does it maybe use a bad user agent or is there a proxy error?

The taskotron team determined that this is a problem in rpmlint itself and asked me to open a bug report here:

https://phab.qa.fedoraproject.org/T879#12545

Comment 1 Fedora End Of Life 2017-02-28 11:01:07 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 2 Tom "spot" Callaway 2017-08-31 17:26:02 UTC
Okay, what is happening here is this:

You've got:

Source0: https://yt-dl.org/downloads/2017.08.23/youtube-dl-2017.08.23.tar.gz

rpmlint says:

youtube-dl.spec: W: invalid-url Source0: https://yt-dl.org/downloads/2017.08.23/youtube-dl-2017.08.23.tar.gz HTTP Error 403: Forbidden

The URL is a 302 redirect to https://github.com/rg3/youtube-dl/releases/download/2017.08.23/youtube-dl-2017.08.23.tar.gz. But! The github http server doesn't respond properly to a HEAD request, which is how rpmlint checks the Source URLs.

It's all documented here:
https://github.com/rpm-software-management/rpmlint/issues/71

We've already blacklisted github.com from that rpmlint check, so if you want that error to go away, please switch to the github urls for those source files. (I could add yt-dl.org to the blacklist, but since it is just a redirect, I'd rather not)

Comment 3 Till Maas 2017-08-31 20:19:58 UTC
Thank you for the analysis, I changed it in the youtube-dl.spec. Have you considered using a Range: bytes=0-0 header witha a GET request as a fallback when HEAD does not work?


Note You need to log in before you can comment on or make changes to this bug.