Bug 1414984 - Add storage domain dialog doesn't report validation error
Summary: Add storage domain dialog doesn't report validation error
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.1.0-beta
: 4.1.0.3
Assignee: Tal Nisan
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-19 21:35 UTC by jniederm
Modified: 2017-02-01 14:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-01 14:48:11 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.1+


Attachments (Terms of Use)
NFS creation after the fix (35.53 KB, image/png)
2017-01-22 11:00 UTC, Tal Nisan
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 70957 0 master MERGED webadmin: Extract messages section from expander in new NFS domain popup 2017-01-22 12:35:48 UTC
oVirt gerrit 70965 0 ovirt-engine-4.1 MERGED webadmin: Extract messages section from expander in new NFS domain popup 2017-01-23 10:22:04 UTC
oVirt gerrit 70967 0 ovirt-engine-4.1 MERGED webadmin: Highlight path input in new domain popup when connection exists 2017-01-22 13:43:31 UTC
oVirt gerrit 70970 0 ovirt-engine-4.1 MERGED webadmin: Highlight path input in new domain popup when connection exists 2017-01-23 10:22:56 UTC

Description jniederm 2017-01-19 21:35:23 UTC
Description of problem:
If adding a new nfs storage domain with different name but same 'export path' then the 'ok' button does nothing (just a blink). Which is correct but no explaining message is shown.

Version-Release number of selected component (if applicable):
4.2 master, commit 461eb97

How reproducible:
100%

Steps to Reproduce:
1. Let's have a nfs storage domain added.
2. Open dialog to add new storage domain with same export path as previous one but different name
3. Click ok

Actual results:
Dialog is not closed, no error message show

Expected results:
Message is shown explaining that there can't be two storage domains with the same export path.

Additional info:

Comment 1 Tal Nisan 2017-01-22 10:59:57 UTC
The error message did appear but was hidden within the 'Custom Connection Parameters' section which is not expanded by default, I've extracted the messages section so it will be visible at all times as shown in the screenshot

Comment 2 Tal Nisan 2017-01-22 11:00:33 UTC
Created attachment 1243311 [details]
NFS creation after the fix

Comment 3 Sandro Bonazzola 2017-01-23 14:29:51 UTC
Tal, https://gerrit.ovirt.org/#/c/70965/ is not included in 4.1.0 RC and the bug is not marked as a blocker. Moving to 4.1.1.

Comment 4 Raz Tamir 2017-01-31 18:06:42 UTC
Verified on ovirt-engine-4.1.0.3-0.1.el7

Tried to create an NFS storage domain with an already existing export path and got error:
"Create operation failed. Storage connection is already used by the following storage domain: SD1"


Note You need to log in before you can comment on or make changes to this bug.