Description of problem:

For Cloud Orchestration Provisioning, check_provisioned does not properly handle 'rollback_complete' status and likely 'delete_complete', /failed$/, /canceled$/ statuses as well.  When rollback_complete is found the current logic falls through into a retry causing check_provisioned to continue to run until reaching the maximum number of attempts.  This prevents update_serviceprovision_status from handling the error.

Version-Release number of selected component (if applicable):

5.6.3.3 though I checked the latest and check_provisioned script appears identical.

How reproducible:

Every time.

Steps to Reproduce:
1. Induce a cloud orchestration provision that will rollback.
2. Observe the log and note the task does not complete until check_provisioned reaches maximum attempts.

Additional info:

I had success fixing this by adding a return to the bottom of the when for rollback_complete et. al.

Current code:

  when 'rollback_complete', 'delete_complete', /failed$/, /canceled$/
    $evm.root['ae_result'] = 'error'
    $evm.root['ae_reason'] = reason
  else

Code which seems to fix the issue:

  when 'rollback_complete', 'delete_complete', /failed$/, /canceled$/
    $evm.root['ae_result'] = 'error'
    $evm.root['ae_reason'] = reason
    return
  else

diff of fixed current

$ diff check_provisioned*
30d29
<     return