Bug 1415545 - [Patch] Misc refactoring patches for rh-rhui-tools to follow popular coding guidelines
Summary: [Patch] Misc refactoring patches for rh-rhui-tools to follow popular coding g...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Update Infrastructure for Cloud Providers
Classification: Red Hat
Component: Tools
Version: 3.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: 3.0.7
: 3.0.x
Assignee: RHUI Bug List
QA Contact: Vratislav Hutsky
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-23 02:32 UTC by Satoru SATOH
Modified: 2019-01-23 18:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-01-23 18:05:13 UTC
Target Upstream Version:


Attachments (Terms of Use)
Patch removes use of deprecated lang features like reduce, filter, etc. (3.45 KB, patch)
2017-01-23 02:34 UTC, Satoru SATOH
no flags Details | Diff
Patch simplify true/false statements (16.58 KB, patch)
2017-01-23 02:36 UTC, Satoru SATOH
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:0149 0 None None None 2019-01-23 18:05:17 UTC

Description Satoru SATOH 2017-01-23 02:32:13 UTC
Description of problem:
Current code of rh-rhui-tools does not look following popular python
coding guidelines that maybe cause decrease of maintainability.

Version-Release number of selected component (if applicable):
RHUI v3 beta.2

Additional info:
I'll upload some PoC patches not tested (unit tests
are must for safer refactoring but it looks not unfortunately.)

Comment 1 Satoru SATOH 2017-01-23 02:34:19 UTC
Created attachment 1243504 [details]
Patch removes use of deprecated lang features like reduce, filter, etc.

@see https://google.github.io/styleguide/pyguide.html#Deprecated_Language_Features

Comment 4 Satoru SATOH 2017-01-23 02:36:04 UTC
Created attachment 1243505 [details]
Patch simplify true/false statements

https://google.github.io/styleguide/pyguide.html#True/False_evaluations

Comment 9 errata-xmlrpc 2019-01-23 18:05:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0149


Note You need to log in before you can comment on or make changes to this bug.