Description of problem: At this point there is no way to determine if the tests have failed based on the exit of rpmgrill. It always exits with 0, even if tests have failed. Version-Release number of selected component (if applicable): 0.30 How reproducible: 100% Steps to Reproduce: Run rpmgrill against packages with packaging errors. Check the exit code. Actual results: Exit status is 0. Expected results: Exit code reflects a failed test and should be non-zero Additional info:
Added feature: https://github.com/default-to-open/rpmgrill/commit/640941cbcf0ced8fa1f3f51b3fd56e7a950944c2 Had to adjust the rpmgrill-unpack-rpms command to also copy the build logs into the unpack directory.
Tested with broken and not broken RPM packages: t/data/rpm_with_errors $ rpmgrill unpacked t/data/rpm_with_errors $ echo $? 1 t/data/rpm_without_errors $ rpmgrill-unpack-rpms . t/data/rpm_without_errors $ rpmgrill unpacked t/data/rpm_without_errors $ echo $? 0
Shipped with 0.31 release: https://github.com/default-to-open/rpmgrill/releases/tag/0.31