Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1415993 - Review Request: perl-Time-Tiny - Time object, with as little code as possible
Summary: Review Request: perl-Time-Tiny - Time object, with as little code as possible
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-24 10:42 UTC by Jitka Plesnikova
Modified: 2017-01-25 13:37 UTC (History)
2 users (show)

Fixed In Version: perl-Time-Tiny-1.07-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-25 13:37:27 UTC
Type: ---
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2017-01-24 10:42:10 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Time-Tiny/perl-Time-Tiny.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Time-Tiny/perl-Time-Tiny-1.07-1.fc26.src.rpm

Description:
Time::Tiny implements an extremely lightweight object that represents
a time, without any time data.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2017-01-24 11:11:19 UTC
URL and Source0 addresses are usable. Ok.
Source archive (SHA-256: 44bd1ac525898cccc592ae66dd4ceeacaeeb4a3365fb4e2c1b1bdd2a060e1804) is original. Ok.
Summary verified from lib/Time/Tiny.pm. Ok.
Description verified from lib/Time/Tiny.pm. Ok.
License verified from README, LICENSE, lib/Time/Tiny.pm. Ok.
No XS code, noarch BuildArch is Ok.
CPAN::Meta and CPAN::Meta::Prereqs are not needed for tests. Ok.
BuildRequires are Ok.
All tests pass. Ok.

$ rpmlint perl-Time-Tiny.spec ../SRPMS/perl-Time-Tiny-1.07-1.fc26.src.rpm ../RPMS/noarch/perl-Time-Tiny-1.07-1.fc26.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Time-Tiny-1.07-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan 24 12:04 /usr/share/doc/perl-Time-Tiny
-rw-r--r--    1 root    root                     3460 Jun 23  2016 /usr/share/doc/perl-Time-Tiny/CONTRIBUTING.mkdn
-rw-r--r--    1 root    root                      633 Jun 23  2016 /usr/share/doc/perl-Time-Tiny/Changes
-rw-r--r--    1 root    root                     6883 Jun 23  2016 /usr/share/doc/perl-Time-Tiny/README
drwxr-xr-x    2 root    root                        0 Jan 24 12:04 /usr/share/licenses/perl-Time-Tiny
-rw-r--r--    1 root    root                    18349 Jun 23  2016 /usr/share/licenses/perl-Time-Tiny/LICENSE
-rw-r--r--    1 root    root                     3914 Jan 24 12:04 /usr/share/man/man3/Time::Tiny.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan 24 12:04 /usr/share/perl5/vendor_perl/Time
-rw-r--r--    1 root    root                    11314 Jun 23  2016 /usr/share/perl5/vendor_perl/Time/Tiny.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Time-Tiny-1.07-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(Carp)
      1 perl(DateTime)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Time-Tiny-1.07-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(Time::Tiny) = 1.07
      1 perl-Time-Tiny = 1.07-1.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Time-Tiny-1.07-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17400757). Ok.

Package is in line with Perl and Fedora packaging guidelines.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-01-25 13:16:55 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Time-Tiny

Comment 3 Jitka Plesnikova 2017-01-25 13:37:27 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.