Bug 1416059 - Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl
Summary: Review Request: perl-Git-Wrapper - Wrap git command-line interface for Perl
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1416158
TreeView+ depends on / blocked
 
Reported: 2017-01-24 13:56 UTC by Petr Pisar
Modified: 2017-02-07 00:53 UTC (History)
2 users (show)

Fixed In Version: perl-Git-Wrapper-0.047-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-07 00:23:41 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2017-01-24 13:56:44 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Git-Wrapper/perl-Git-Wrapper.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Git-Wrapper/perl-Git-Wrapper-0.047-1.fc26.src.rpm
Description:
Git::Wrapper provides an API for git that uses Perl data structures for
argument passing, instead of CLI-style --options as Git does.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2017-01-25 11:16:44 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Git-Wrapper-0.047-1.fc26.noarch.rpm | sort | uniq -c
      1 git-core
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.6.0
      1 perl(File::Temp)
      1 perl(File::chdir)
      1 perl(Git::Wrapper::Exception)
      1 perl(Git::Wrapper::File::RawModification)
      1 perl(Git::Wrapper::Log)
      1 perl(Git::Wrapper::Status)
      1 perl(Git::Wrapper::Statuses)
      1 perl(IPC::Cmd)
      1 perl(IPC::Open3)
      1 perl(Scalar::Util)
      1 perl(Sort::Versions)
      1 perl(Symbol)
      1 perl(overload)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Git-Wrapper-0.047-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Git::Wrapper) = 0.047
      1 perl(Git::Wrapper::Exception) = 0.047
      1 perl(Git::Wrapper::File::RawModification) = 0.047
      1 perl(Git::Wrapper::Log) = 0.047
      1 perl(Git::Wrapper::Status) = 0.047
      1 perl(Git::Wrapper::Statuses) = 0.047
      1 perl-Git-Wrapper = 0.047-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Git-Wrapper*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

FIX: Please add build-requires 'make' and 'findutils'. They are used in
     spec file.

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved.

Comment 2 Gwyn Ciesla 2017-01-25 13:23:19 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Git-Wrapper

Comment 3 Petr Pisar 2017-01-25 15:29:26 UTC
Thank you for the review and the repository. I added the the dependencies.

Comment 4 Fedora Update System 2017-01-25 15:31:03 UTC
perl-Git-Wrapper-0.047-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c3fe9e7108

Comment 5 Fedora Update System 2017-01-25 15:31:12 UTC
perl-Git-Wrapper-0.047-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc00f9f341

Comment 6 Fedora Update System 2017-01-25 23:19:34 UTC
perl-Git-Wrapper-0.047-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc00f9f341

Comment 7 Fedora Update System 2017-01-28 04:53:41 UTC
perl-Git-Wrapper-0.047-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c3fe9e7108

Comment 8 Fedora Update System 2017-02-07 00:23:41 UTC
perl-Git-Wrapper-0.047-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2017-02-07 00:53:18 UTC
perl-Git-Wrapper-0.047-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.