Bug 1416492 - Review Request: perl-Task-Kensho-XML - Glimpse at an Enlightened Perl (XML Development)
Summary: Review Request: perl-Task-Kensho-XML - Glimpse at an Enlightened Perl (XML De...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-25 15:49 UTC by Jitka Plesnikova
Modified: 2017-01-26 14:14 UTC (History)
2 users (show)

Fixed In Version: perl-Task-Kensho-XML-0.39-1.fc26
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-01-26 14:14:35 UTC
Type: ---
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2017-01-25 15:49:13 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-Task-Kensho-XML/perl-Task-Kensho-XML.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Task-Kensho-XML/perl-Task-Kensho-XML-0.39-1.fc26.src.rpm

Description:
Task::Kensho is a list of recommended modules for Enlightened Perl
development. CPAN is wonderful, but there are too many wheels and you have
to pick and choose amongst the various competing technologies.

Fedora Account System Username: jplesnik@redhat.com

Comment 1 Petr Pisar 2017-01-26 10:04:16 UTC
URL and Source0 addresses are usable.
Source archive (SHA-256: c7edcc52a397bd165cdb71a409fae140825275d913d0c37d2837cbf78c63396a) is original.
Summary is good.
Description is good.
License verified from LICENSE and lib/Task/Kensho/XML.pm. Ok.
No XS code, noarch BuildArch is Ok.
Module::Build::Tiny not needed. Ok.

TODO: Do not build-require modules (RDF::Trine, XML::Generator::PerlData, XML::LibXML, XML::LibXSLT,  XML::SAX, XML::SAX::Writer) that are not needed at build or check time. The tests pass even without them.

CPAN::Meta and CPAN::Meta::Prereqs not helpful. Ok.

$ rpmlint perl-Task-Kensho-XML.spec ../SRPMS/perl-Task-Kensho-XML-0.39-1.fc26.src.rpm ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm 
perl-Task-Kensho-XML.src: W: spelling-error %description -l en_US amongst -> among st, among-st, among
perl-Task-Kensho-XML.noarch: W: spelling-error %description -l en_US amongst -> among st, among-st, among
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Jan 26 10:22 /usr/share/doc/perl-Task-Kensho-XML
-rw-r--r--    1 root    root                     6777 May 14  2016 /usr/share/doc/perl-Task-Kensho-XML/Changes
-rw-r--r--    1 root    root                     1602 May 14  2016 /usr/share/doc/perl-Task-Kensho-XML/README
drwxr-xr-x    2 root    root                        0 Jan 26 10:22 /usr/share/licenses/perl-Task-Kensho-XML
-rw-r--r--    1 root    root                    18352 May 14  2016 /usr/share/licenses/perl-Task-Kensho-XML/LICENSE
-rw-r--r--    1 root    root                     3054 Jan 26 10:22 /usr/share/man/man3/Task::Kensho::XML.3pm.gz
drwxr-xr-x    2 root    root                        0 Jan 26 10:22 /usr/share/perl5/vendor_perl/Task
drwxr-xr-x    2 root    root                        0 Jan 26 10:22 /usr/share/perl5/vendor_perl/Task/Kensho
-rw-r--r--    1 root    root                     4281 May 14  2016 /usr/share/perl5/vendor_perl/Task/Kensho/XML.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(RDF::Trine)
      1 perl(strict)
      1 perl(warnings)
      1 perl(XML::Generator::PerlData)
      1 perl(XML::LibXML)
      1 perl(XML::LibXSLT)
      1 perl(XML::SAX)
      1 perl(XML::SAX::Writer)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm | sort -f | uniq -c
      1 perl(Task::Kensho::XML) = 0.39
      1 perl-Task-Kensho-XML = 0.39-1.fc26
Binary provides are Ok.

$ resolvedeps f26-build ../RPMS/noarch/perl-Task-Kensho-XML-0.39-1.fc26.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17420376). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please fix the `TODO' item before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2017-01-26 13:59:03 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Task-Kensho-XML

Comment 3 Jitka Plesnikova 2017-01-26 14:14:35 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.