Spec URL: https://jplesnik.fedorapeople.org/perl-Email-MIME-Kit/perl-Email-MIME-Kit.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Email-MIME-Kit/perl-Email-MIME-Kit-3.000005-1.fc26.src.rpm Description: Email::MIME::Kit is a templating system for email messages. Instead of trying to be yet another templating system for chunks of text, it makes it easy to build complete email messages. Fedora Account System Username: jplesnik
URL and Source0 addresses are usable. Ok. Source archive (SHA-256: 8fcfbbe193404d8ad20eecbe569e37abe43e4a4995eb8b670cd7ef79c5f86ec3) is Ok. Summary verified from lib/Email/MIME/Kit.pm. TODO: The package is about creating e-mail messages. Therefore I'd change the summary to "Build e-mail messages from templates". Description verified from lib/Email/MIME/Kit.pm. Ok. License verified from lib/Email/MIME/Kit/Renderer/TestRenderer.pm, lib/Email/MIME/Kit/ManifestReader/YAML.pm, lib/Email/MIME/Kit/ManifestReader/JSON.pm, lib/Email/MIME/Kit/Assembler/Standard.pm, lib/Email/MIME/Kit/Role/ManifestDesugarer.pm, lib/Email/MIME/Kit/Role/ManifestReader.pm, lib/Email/MIME/Kit/Role/Validator.pm, lib/Email/MIME/Kit/Role/KitReader.pm, lib/Email/MIME/Kit/Role/Component.pm, lib/Email/MIME/Kit/Role/Assembler.pm, lib/Email/MIME/Kit/Role/Renderer.pm, lib/Email/MIME/Kit/KitReader/Dir.pm, lib/Email/MIME/Kit.pm, LICENSE, and README. Ok. Notice: The t/kits/test.mkit/logo.jpg contains EXIF data with "Copyright Apple, Inc., 2009" that I consider meaningless because it's attached to an ICC profile name. The picture itself is a "company" logo <http://www.codesimply.com/contact.html> and I could not find it in the U.S. trademark database, thus I believe the redistribution is fine. No XS code, noarch BuildArch is Ok. CPAN::Meta and CPAN::Meta::Prereqs are not helpful. Ok. All tests pass. Ok. $ rpmlint perl-Email-MIME-Kit.spec ../SRPMS/perl-Email-MIME-Kit-3.000005-1.fc26.src.rpm ../RPMS/noarch/perl-Email-MIME-Kit-3.000005-1.fc26.noarch.rpm perl-Email-MIME-Kit.src: W: spelling-error %description -l en_US templating -> contemplating, template, tempting perl-Email-MIME-Kit.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Email-MIME-Kit-3.000005-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/doc/perl-Email-MIME-Kit -rw-r--r-- 1 root root 3553 Sep 20 17:22 /usr/share/doc/perl-Email-MIME-Kit/Changes -rw-r--r-- 1 root root 373 Sep 20 17:22 /usr/share/doc/perl-Email-MIME-Kit/README drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/licenses/perl-Email-MIME-Kit -rw-r--r-- 1 root root 18355 Sep 20 17:22 /usr/share/licenses/perl-Email-MIME-Kit/LICENSE -rw-r--r-- 1 root root 3119 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit.3pm.gz -rw-r--r-- 1 root root 1487 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Assembler::Standard.3pm.gz -rw-r--r-- 1 root root 1294 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::KitReader::Dir.3pm.gz -rw-r--r-- 1 root root 1294 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::ManifestReader::JSON.3pm.gz -rw-r--r-- 1 root root 1293 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::ManifestReader::YAML.3pm.gz -rw-r--r-- 1 root root 1845 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Renderer::TestRenderer.3pm.gz -rw-r--r-- 1 root root 1440 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::Assembler.3pm.gz -rw-r--r-- 1 root root 1414 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::Component.3pm.gz -rw-r--r-- 1 root root 1599 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::KitReader.3pm.gz -rw-r--r-- 1 root root 1657 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::ManifestDesugarer.3pm.gz -rw-r--r-- 1 root root 1451 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::ManifestReader.3pm.gz -rw-r--r-- 1 root root 1477 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::Renderer.3pm.gz -rw-r--r-- 1 root root 1509 Jan 30 13:41 /usr/share/man/man3/Email::MIME::Kit::Role::Validator.3pm.gz drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit -rw-r--r-- 1 root root 12543 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit.pm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Assembler -rw-r--r-- 1 root root 10306 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Assembler/Standard.pm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit/KitReader -rw-r--r-- 1 root root 972 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/KitReader/Dir.pm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit/ManifestReader -rw-r--r-- 1 root root 910 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/ManifestReader/JSON.pm -rw-r--r-- 1 root root 999 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/ManifestReader/YAML.pm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Renderer -rw-r--r-- 1 root root 3097 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Renderer/TestRenderer.pm drwxr-xr-x 2 root root 0 Jan 30 13:41 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role -rw-r--r-- 1 root root 1279 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/Assembler.pm -rw-r--r-- 1 root root 1209 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/Component.pm -rw-r--r-- 1 root root 2113 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/KitReader.pm -rw-r--r-- 1 root root 2781 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/ManifestDesugarer.pm -rw-r--r-- 1 root root 1383 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/ManifestReader.pm -rw-r--r-- 1 root root 1365 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/Renderer.pm -rw-r--r-- 1 root root 1598 Sep 20 17:22 /usr/share/perl5/vendor_perl/Email/MIME/Kit/Role/Validator.pm File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Email-MIME-Kit-3.000005-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(:VERSION) >= 5.8.0 1 perl(Email::MessageID) >= 1.400 1 perl(Email::MIME) >= 1.930 1 perl(Email::MIME::Creator) 1 perl(Encode) 1 perl(File::Basename) 1 perl(File::Spec) 1 perl(JSON) >= 2 1 perl(Module::Runtime) 1 perl(Moose) >= 0.65 1 perl(Moose::Role) 1 perl(Moose::Util::TypeConstraints) 1 perl(String::RewritePrefix) 1 perl(YAML::XS) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Email-MIME-Kit-3.000005-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Email::MIME::Kit) = 3.000005 1 perl(Email::MIME::Kit::Assembler::Standard) = 3.000005 1 perl(Email::MIME::Kit::KitReader::Dir) = 3.000005 1 perl(Email::MIME::Kit::ManifestReader::JSON) = 3.000005 1 perl(Email::MIME::Kit::ManifestReader::YAML) = 3.000005 1 perl(Email::MIME::Kit::Renderer::TestRenderer) = 3.000005 1 perl(Email::MIME::Kit::Role::Assembler) = 3.000005 1 perl(Email::MIME::Kit::Role::Component) = 3.000005 1 perl(Email::MIME::Kit::Role::KitReader) = 3.000005 1 perl(Email::MIME::Kit::Role::ManifestDesugarer) = 3.000005 1 perl(Email::MIME::Kit::Role::ManifestReader) = 3.000005 1 perl(Email::MIME::Kit::Role::Renderer) = 3.000005 1 perl(Email::MIME::Kit::Role::Validator) = 3.000005 1 perl-Email-MIME-Kit = 3.000005-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Email-MIME-Kit-3.000005-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. The package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17501587). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Email-MIME-Kit
Thank you for the review and the repository.