Description of problem: CloudForms seems to accept JSON CloudFormation Templates only. When attempting to use a YAML template, validation fails. Version-Release number of selected component (if applicable): Up through 5.7.0.17 How reproducible: 100% Steps to Reproduce: 1.Services -> Catalogs -> (Accordian Menu)Orchestration templates 2.Configuration Button -> Create New Orchestration template 3.Populate Name, Description, Leave Template Type as Amazon CloudFormation 4.Populate Template field (Codemirror field) with a simple CLoudFormation YAML template: AWSTemplateFormatVersion: '2010-09-09' Resources: S3BucketForWebsiteContent: Type: AWS::S3::Bucket Properties: AccessControl: PublicRead WebsiteConfiguration: IndexDocument: index.html ErrorDocument: error.html Alternate repro: 1. Locate an existing CloudFormation stack deployed with a YAML template. 2. Click to display the orchestration template. 3. Click Configuration Button -> "Make Orchestration Template Orderable" Actual results: Error during 'Orchestration Template creation': 743: unexpected token at 'AWSTemplateFormatVersion: '2010-09-09' Resources: S3BucketForWebsiteContent: Type: AWS::S3::Bucket Properties: AccessControl: PublicRead WebsiteConfiguration: IndexDocument: index.html ErrorDocument: error.html ' Expected results: New CloudFormation Orchestration Template should be created in CloudForms Additional info:
AWS introduced YAML formatted templates last year[1]. MIQ will need to be updated to support the YAML format for CloudFormation. [1] https://aws.amazon.com/about-aws/whats-new/2016/09/aws-cloudformation-introduces-yaml-template-support-and-cross-stack-references/
https://www.pivotaltracker.com/story/show/141706225
https://github.com/ManageIQ/manageiq/pull/14843
https://github.com/ManageIQ/manageiq-providers-openstack/pull/76
https://github.com/ManageIQ/manageiq-providers-azure/pull/111
https://github.com/ManageIQ/manageiq-providers-amazon/pull/286
https://github.com/ManageIQ/manageiq-schema/pull/55
New commit detected on ManageIQ/manageiq-providers-amazon/master: https://github.com/ManageIQ/manageiq-providers-amazon/commit/63b51557e7f1aba03b32d6578ecfb02ab95fc310 commit 63b51557e7f1aba03b32d6578ecfb02ab95fc310 Author: Bill Wei <bilwei> AuthorDate: Tue Aug 15 10:12:51 2017 -0400 Commit: Bill Wei <bilwei> CommitDate: Tue Aug 29 09:39:56 2017 -0400 Prepare to move OrchestrationTemplate to each provider Move OrchestrationTemplateCfn to manageiq-providers-amazon. This is a step before the migration. https://bugzilla.redhat.com/show_bug.cgi?id=1417021 .../manageiq/providers/amazon/cloud_manager.rb | 3 +- .../amazon/cloud_manager/orchestration_template.rb | 192 +++++++++++++++++++++ .../cloud_manager/orchestration_template_spec.rb | 184 ++++++++++++++++++++ 3 files changed, 378 insertions(+), 1 deletion(-) create mode 100644 app/models/manageiq/providers/amazon/cloud_manager/orchestration_template.rb create mode 100644 spec/models/manageiq/providers/amazon/cloud_manager/orchestration_template_spec.rb
New commit detected on ManageIQ/manageiq-providers-azure/master: https://github.com/ManageIQ/manageiq-providers-azure/commit/7cc47a65fef6e5c334c6d796ec7795c7881b42ea commit 7cc47a65fef6e5c334c6d796ec7795c7881b42ea Author: Bill Wei <bilwei> AuthorDate: Sun Aug 13 19:57:01 2017 -0400 Commit: Bill Wei <bilwei> CommitDate: Tue Aug 29 09:46:49 2017 -0400 Prepare to move OrchestrationTemplate to each provider Move OrchestrationTemplateAzure to manageiq-providers-azure. This is a step before the migration. https://bugzilla.redhat.com/show_bug.cgi?id=1417021 .../manageiq/providers/azure/cloud_manager.rb | 1 + .../azure/cloud_manager/orchestration_template.rb | 133 +++++++++++++++++++++ .../cloud_manager/orchestration_template_spec.rb | 104 ++++++++++++++++ 3 files changed, 238 insertions(+) create mode 100644 app/models/manageiq/providers/azure/cloud_manager/orchestration_template.rb create mode 100644 spec/models/manageiq/providers/azure/cloud_manager/orchestration_template_spec.rb
New commit detected on ManageIQ/manageiq-providers-openstack/master: https://github.com/ManageIQ/manageiq-providers-openstack/commit/3bf372691aaced8a83b47591b59ea34084e2fdd4 commit 3bf372691aaced8a83b47591b59ea34084e2fdd4 Author: Bill Wei <bilwei> AuthorDate: Thu Aug 10 11:33:14 2017 -0400 Commit: Bill Wei <bilwei> CommitDate: Sun Aug 20 12:28:14 2017 -0400 Prepare to move OrchestrationTemplate to each provider Move the template classes to the corresponding provider repository. This is a step before the migration. https://bugzilla.redhat.com/show_bug.cgi?id=1417021 .../manageiq/providers/openstack/cloud_manager.rb | 2 + .../cloud_manager/orchestration_template.rb | 131 ++++++++++++++ .../openstack/cloud_manager/vnfd_template.rb | 69 ++++++++ .../cloud_manager/orchestration_template_spec.rb | 194 +++++++++++++++++++++ .../openstack/cloud_manager/vnfd_template_spec.rb | 27 +++ 5 files changed, 423 insertions(+) create mode 100644 app/models/manageiq/providers/openstack/cloud_manager/orchestration_template.rb create mode 100644 app/models/manageiq/providers/openstack/cloud_manager/vnfd_template.rb create mode 100644 spec/models/manageiq/providers/openstack/cloud_manager/orchestration_template_spec.rb create mode 100644 spec/models/manageiq/providers/openstack/cloud_manager/vnfd_template_spec.rb
https://github.com/ManageIQ/manageiq-providers-amazon/pull/298
New commit detected on ManageIQ/manageiq-providers-amazon/master: https://github.com/ManageIQ/manageiq-providers-amazon/commit/5978c5b9cfeca5468b64bb7ab252e3ecd92f7cb9 commit 5978c5b9cfeca5468b64bb7ab252e3ecd92f7cb9 Author: Bill Wei <bilwei> AuthorDate: Fri Sep 15 18:36:50 2017 -0400 Commit: Bill Wei <bilwei> CommitDate: Wed Sep 20 11:58:05 2017 -0400 Add YAML support for Amazon OrchestrationTemplate https://bugzilla.redhat.com/show_bug.cgi?id=1417021 .../amazon/cloud_manager/orchestration_template.rb | 57 +++++++++---- spec/factories/orchestration_template.rb | 19 +++++ .../orchestration_templates/cfn_parameters.json | 96 ++++++++++++++++++++++ .../orchestration_templates/cfn_parameters.yaml | 75 +++++++++++++++++ .../cloud_manager/orchestration_template_spec.rb | 36 ++++++-- 5 files changed, 259 insertions(+), 24 deletions(-) create mode 100644 spec/factories/orchestration_template.rb create mode 100644 spec/fixtures/orchestration_templates/cfn_parameters.json create mode 100644 spec/fixtures/orchestration_templates/cfn_parameters.yaml
New commit detected on ManageIQ/manageiq-schema/master: https://github.com/ManageIQ/manageiq-schema/commit/0d8438cb14a492cee01617fe23ce66b9d2494839 commit 0d8438cb14a492cee01617fe23ce66b9d2494839 Author: Bill Wei <bilwei> AuthorDate: Sun Aug 20 21:29:56 2017 -0400 Commit: Bill Wei <bilwei> CommitDate: Mon Sep 18 16:17:49 2017 -0400 Update orchestration template types Migrate OrchestrationTemplateCfn to ManageIQ::Providers::Amazon::CloudManager::OrchestrationTemplate OrchestrationTemplateHot to ManageIQ::Providers::Openstack::CloudManager::OrchestrationTemplate OrchestrationTemplateAzure to ManageIQ::Providers::Azure::CloudManager::OrchestrationTemplate OrchestrationTemplateVnfd to ManagerIQ::Provders::Openstack::CloudManager::VnfdTemplate https://bugzilla.redhat.com/show_bug.cgi?id=1417021 ...085511_update_type_of_orchestration_template.rb | 45 +++++++++++++++++ ...1_update_type_of_orchestration_template_spec.rb | 57 ++++++++++++++++++++++ 2 files changed, 102 insertions(+) create mode 100644 db/migrate/20170821085511_update_type_of_orchestration_template.rb create mode 100644 spec/migrations/20170821085511_update_type_of_orchestration_template_spec.rb
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:0380