Created attachment 1246266 [details]
Description of problem:
I am trying to set up Manila with NetApp driver in Overcloud using Heat environment files. I set up the environment files and included them with a "-e" parameter in Overcloud creation.
The deployment fails at:
AllNodesDeploySteps | OS::TripleO::PostDeploySteps
If i check the os-collect-config logs I see this:
Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config: Error: Could not find data item manila::backend::netapp::netapp_trace_flags in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/pacemaker/manila.pp:117 on node overcloud-controller-0.localdomain
Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config: Error: Could not find data item manila::backend::netapp::netapp_trace_flags in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/pacemaker/manila.pp: 117 on node overcloud-controller-0.localdomain
Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config: [2017-01-31 03:55:02,102] (heat-config) [ERROR] Error running /var/lib/heat-config/heat-config-puppet/bce686a8-acdf-4ba9-b903-0b
Version-Release number of selected component (if applicable):
Attaching the used manila-netapp-config.yaml file.
Steps to Reproduce:
1.Include the env file manila-netapp-config.yaml in the overcloud deploy command with an "-e" option
Taking a quick look at this shows that the netapp_trace_flags parameter is present but is empty. I wonder if it is a parameter that, if present, needs to have a value or if you do not need tracing that you can just remove that parameter. Will have to investigate.
The netapp_trace_flags option can be set to the empty string. That's no problem.
ddomingo pointed me to this bug.
As a workaround, you might want to set ManilaNetappTraceFlags to either ' ' or "''" rather than ''. I think Heat interprets '' as a null value and ignores the param when populating the hiera data.
So depending on what you want netapp_trace_flags to conatin, try one of the following:
ManilaNetappTraceFlags: ' ' # sets to blank space
ManilaNetappTraceFlags: "''" # sets to single quotes
This bugzilla has been removed from the release and needs to be reviewed for targeting another release.
related issue: https://bugzilla.redhat.com/show_bug.cgi?id=1313220
Although we've posted a review that sets ManilaNetAppTraceFlags to ' ' instead of to '', (1) the latter setting should theoretically work, and (2) we're not able to replicate the issue using upstream tripleo master code. Perhaps the related issue cited in https://bugzilla.redhat.com/show_bug.cgi?id=1417980#c6 has been resolved.
Since the customer has reported in IRC that the workaround of setting the trace flags to 'method' in his version of the manila netapp environment file works and is acceptable we're going to see if we can reproduce the issue with RHOS10 OSPd and if so get a better understanding of the difference with master before pushing ahead with the current posted review.
I tried this out on the latest available OSP-10 build and I was able to get the install to fail with the netapp_trace_flags value not present. So I can verify that this is indeed present in the current build of OSP-10.
upstream patch for newton:
A fix for later releases is not needed because in Ocata Tripleo switched to JSON format of hieradata - https://review.openstack.org/#/c/384757/
Using the 2017-05-23.4 OSP-10 puddle with the openstack-tripleo-heat-templates-5.2.0-18.el7ost.noarch package I was able to set up the OpenStack instance without specifying the ManilaNetAppTraceFlags option in the parameters to the Heat template that configures the NetApp cDOT Manila driver. The OSP instance was setup correctly. After this, I logged into each controller node in the environment and looked at the Manila configuration files to ensure that if the option was specified in the configuration file that it did not have a value. Every node had the option present in the NetApp configuration stanza, but none had values, thus meaning that no tracing was enabled. Marking the bug as VERIFIED.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.