Bug 1418023 - `oc create route` performs no validation on client side
Summary: `oc create route` performs no validation on client side
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Jacob Tanenbaum
QA Contact: zhaozhanqi
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-01-31 15:59 UTC by Jacob Tanenbaum
Modified: 2022-08-04 22:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-03 21:15:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Jacob Tanenbaum 2017-01-31 15:59:04 UTC
Description of problem:

`oc create route` relies on connection to the server to perform all validation, So during dry-run and attempting to output a route object erroneous values will not be checked.

Comment 1 Ben Bennett 2017-02-02 14:43:41 UTC
RamR observes:

@knobunc adding some of these checks on client side could be problematic. One is that older cli clients would behave differently vis-a-vis newer cli clients + what happens when the server validation changes say for a list of choices from [foo, bar] to [foo, bar, baz] or even [one, two]? The older cli client checks would be invalid at that point or worse yet even block valid values.

Comment 2 Ben Bennett 2017-02-03 21:15:14 UTC
Clayton says:
  We need less client side validation, and more serverside. Clients should not  make decisions about valid values.
--

Based on that, I'm closing this.


Note You need to log in before you can comment on or make changes to this bug.