Bugzilla (bugzilla.redhat.com) will be under maintenance for infrastructure upgrades and will not be available on July 31st between 12:30 AM - 05:30 AM UTC. We appreciate your understanding and patience. You can follow status.redhat.com for details.
Bug 1418829 - Improve tests
Summary: Improve tests
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-cucumber-core
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jun Aruga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-02 20:14 UTC by Jun Aruga
Modified: 2017-02-03 12:48 UTC (History)
1 user (show)

Fixed In Version: rubygem-cucumber-core-1.5.0-2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-03 12:48:47 UTC
Type: Bug


Attachments (Terms of Use)
Patch to improve tests (1.49 KB, patch)
2017-02-02 20:14 UTC, Jun Aruga
no flags Details | Diff

Description Jun Aruga 2017-02-02 20:14:16 UTC
Created attachment 1247225 [details]
Patch to improve tests

Description of problem:

Right now cucumber-core's tests are run by expecting some errors by
"rspec spec | grep '317 examples, 14 failures'".
This logic might have been reliable for a long time.

However it might be better not to use pipe if possible,
because we can see the result of tests from STDOUT in build.log
I would upload you a patch for that.
I like it will be merged.

Version-Release number of selected component (if applicable):
rubygem-cucumber-core-1.5.0-1

Comment 1 Jun Aruga 2017-02-02 20:17:44 UTC
I checked below things.

License check: ok
rpmlint check: ok
Install check: ok

Comment 2 Vít Ondruch 2017-02-03 09:09:16 UTC
LGTM, thx. I approved you ACL, so feel free to apply the patch.

Comment 3 Jun Aruga 2017-02-03 12:48:47 UTC
Applied the patch to rawhide!


Note You need to log in before you can comment on or make changes to this bug.