Bug 1419267 - Review Request: switchboard-plug-notifications - Switchboard Notifications plug
Summary: Review Request: switchboard-plug-notifications - Switchboard Notifications plug
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
Reported: 2017-02-04 13:44 UTC by Fabio Valentini
Modified: 2017-11-11 17:12 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-02-10 14:21:11 UTC
Type: ---
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2017-02-04 13:44:58 UTC
Spec URL: https://raw.githubusercontent.com/decathorpe/fedora-packaging/2327164506c7f2ef8aba35c549272c02d252ea51/specs/switchboard-plug-notifications/switchboard-plug-notifications.spec

SRPM URL: https://copr-be.cloud.fedoraproject.org/results/decathorpe/staging/fedora-25-x86_64/00507523-switchboard-plug-notifications/switchboard-plug-notifications-0.1.1-4.fc25.src.rpm

Description: Configure which apps should be allowed to show notifications. This is a GModule plugin for Switchboard that configures gsettings keys related to the Notifications plugin for Gala.

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17591641

COPR build for f25 and rawhide: https://copr.fedorainfracloud.org/coprs/decathorpe/staging/build/507523/

Comment 1 Neal Gompa 2017-02-04 16:05:40 UTC
Taking this review.

Comment 2 Neal Gompa 2017-02-04 16:55:13 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[-]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL (v2 or later) (with incorrect FSF address)", "BSD (2
     clause)", "GPL (v3 or later) GPL (v3 or later)", "Unknown or
     generated". 93 files have unknown license. Detailed output of
     licensecheck in /home/makerpm/1419267-switchboard-plug-
[-]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
     /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/locale/ckb,
     /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

Checking: switchboard-plug-notifications-0.1.1-4.fc26.x86_64.rpm
switchboard-plug-notifications.x86_64: W: spelling-error %description -l en_US gsettings -> settings, g settings, insetting
switchboard-plug-notifications.x86_64: W: no-documentation
switchboard-plug-notifications.src: W: spelling-error %description -l en_US gsettings -> settings, g settings, insetting
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Rpmlint (debuginfo)
Checking: switchboard-plug-notifications-debuginfo-0.1.1-4.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
sh: /usr/bin/python: No such file or directory
switchboard-plug-notifications.x86_64: W: spelling-error %description -l en_US gsettings -> settings, g settings, insetting
switchboard-plug-notifications.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

switchboard-plug-notifications-debuginfo (rpmlib, GLIBC filtered):

switchboard-plug-notifications (rpmlib, GLIBC filtered):



Unversioned so-files
switchboard-plug-notifications: /usr/lib64/switchboard/personal/pantheon-notifications-plug/libnotifications-plug.so

Source checksums
https://launchpad.net/switchboard-plug-notifications/loki/0.1.1/+download/switchboard-plug-notifications-0.1.1.tar.xz :
  CHECKSUM(SHA256) this package     : 752387e37611111540cf812d0737b0e675b0eb183639f8d530d3f1939e28e0dd
  CHECKSUM(SHA256) upstream package : 752387e37611111540cf812d0737b0e675b0eb183639f8d530d3f1939e28e0dd

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/bin/fedora-review -b 1419267 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP

Comment 3 Neal Gompa 2017-02-04 16:55:58 UTC
Review notes:

I would suggest changing the Supplements line to the following:

> Supplements:    (switchboard%{?_isa} and gala%{?_isa})

The reason being is that this plug is only useful if both gala and switchboard are installed. It shouldn't be automatically installed in an incomplete state.

Comment 5 Neal Gompa 2017-02-04 17:48:46 UTC

Comment 6 Gwyn Ciesla 2017-02-06 13:41:42 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/switchboard-plug-notifications

Comment 7 Fedora Update System 2017-02-06 17:46:39 UTC
switchboard-plug-notifications-0.1.1-5.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-860bb71fd8

Comment 8 Fedora Update System 2017-02-07 02:49:56 UTC
switchboard-plug-notifications-0.1.1-5.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-860bb71fd8

Comment 9 Fedora Update System 2017-02-10 14:21:11 UTC
switchboard-plug-notifications-0.1.1-5.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.