Hide Forgot
Spec URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/python-backports-unittest_mock.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/python-backports-unittest_mock-1.2.1-1.fc26.src.rpm Description: Provides a function “install()” which makes the “mock” module available as “unittest.mock” on Python 3.2 and earlier. Also advertises a pytest plugin which configures unittest.mock automatically. Fedora Account System Username: kevin scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=17602296 rpmlint says: python2-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python2-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python2-backports-unittest_mock.noarch: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python2-backports-unittest_mock.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python2-backports-unittest_mock.noarch: W: spelling-error %description -l en_US pytest -> testes python2-backports-unittest_mock.noarch: E: wrong-script-interpreter /usr/share/doc/python2-backports-unittest_mock/conf.py /usr/bin/env python3 python3-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python3-backports-unittest_mock.noarch: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python3-backports-unittest_mock.noarch: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python3-backports-unittest_mock.noarch: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python3-backports-unittest_mock.noarch: W: spelling-error %description -l en_US pytest -> testes python3-backports-unittest_mock.noarch: E: wrong-script-interpreter /usr/share/doc/python3-backports-unittest_mock/conf.py /usr/bin/env python3 python-backports-unittest_mock.src: W: spelling-error Summary(en_US) backport -> back port, back-port, backpacker python-backports-unittest_mock.src: W: spelling-error Summary(en_US) unittest -> unit test, unit-test, unities python-backports-unittest_mock.src: W: summary-not-capitalized C backport of unittest mock for python 3.2 and before python-backports-unittest_mock.src: W: spelling-error %description -l en_US unittest -> unit test, unit-test, unities python-backports-unittest_mock.src: W: spelling-error %description -l en_US pytest -> testes 3 packages and 0 specfiles checked; 2 errors, 15 warnings. All of which I think can be ignored.
BTW, this package is needed for the python2 tests of python-setuptools recent versions.
Taking this review.
Review notes: + Package is appropriately named + Subpackages are named correctly per current Python packaging guidelines - %python_provide macro usage is missing on Python module subpackages + License noted correctly - License file is not included in the module subpackages + Unit tests are run and pass in the %check section
Spec URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/python-backports-unittest_mock.spec SRPM URL: http://www.scrye.com/~kevin/fedora/review/python-backports-unittest_mock/python-backports-unittest_mock-1.2.1-2.fc26.src.rpm Added the python_provide macro. Added a copy of the MIT license, as upstream doesn't include it on purpose. I'll argue with them about it later, but in the mean time I am including a copy.
Looks good to me. APPROVED.
Thanks for the quick review! Package requested.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-unittest_mock
Built in rawhide. Thanks.