Bug 1419305

+++ This bug was initially created as a clone of Bug #1418014 +++

+++ This bug was initially created as a clone of Bug #1418011 +++

Description of problem:

client.io-threads is turned on by default in rhgs-3.2.0. While this tunable has improved EC performance significantly, it has adverse effects on the replicate volume performance, following BZs were filed by perf QE while validating this option:


> https://bugzilla.redhat.com/show_bug.cgi?id=1413512 : [Perf]  Inconsistent sequential writes on FUSE due to client-io-threads

> https://bugzilla.redhat.com/show_bug.cgi?id=1404113 : [Perf] 12% Drop in  sequential reads on SMB v1.0

> https://bugzilla.redhat.com/show_bug.cgi?id=1397854 : [Perf] 10% and 20% drop in sequential writes  on SMB v1 and V3 with RHEL 6.8

> https://bugzilla.redhat.com/show_bug.cgi?id=1395204 : 34% drop in Random Writes  from 3.1.3 to 3.2 on FUSE


As these issues can not be addressed within rhgs-3.2.0 timelines as they are related to the design limitation of AFR, it was decided to turn this option off when a replicate volume is created.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2017-01-31 10:30:36 EST ---

This bug is automatically being proposed for the current release of Red Hat Gluster Storage 3 under active development, by setting the release flag 'rhgs‑3.2.0' to '?'. 

If this bug should be proposed for a different release, please manually change the proposed release flag.

--- Additional comment from Atin Mukherjee on 2017-01-31 10:35:46 EST ---

Description of problem:

client.io-threads is turned on by default in 3.9 release. While this tunable has improved EC performance significantly, it has adverse effects on the replicate volume performance, following BZs were filed by perf QE while validating this option:


> https://bugzilla.redhat.com/show_bug.cgi?id=1413512 : [Perf]  Inconsistent sequential writes on FUSE due to client-io-threads

> https://bugzilla.redhat.com/show_bug.cgi?id=1404113 : [Perf] 12% Drop in  sequential reads on SMB v1.0

> https://bugzilla.redhat.com/show_bug.cgi?id=1397854 : [Perf] 10% and 20% drop in sequential writes  on SMB v1 and V3 with RHEL 6.8

> https://bugzilla.redhat.com/show_bug.cgi?id=1395204 : 34% drop in Random Writes  from 3.1.3 to 3.2 on FUSE


As these issues can not be addressed immediately as they are related to the design limitation of AFR, we should turn this option off when a replicate volume is created as a preventive measure.

--- Additional comment from Worker Ant on 2017-01-31 10:44:40 EST ---

REVIEW: https://review.gluster.org/16492 (glusterd: turn of client.io-threads for replicate volumes) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-01-31 12:13:10 EST ---

REVIEW: https://review.gluster.org/16492 (glusterd: turn of client.io-threads for replicate volumes) posted (#3) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-01-31 23:34:26 EST ---

REVIEW: https://review.gluster.org/16492 (glusterd: turn off client.io-threads for replicate volumes) posted (#4) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-02-01 01:12:13 EST ---

REVIEW: https://review.gluster.org/16492 (glusterd: turn off client.io-threads for replicate volumes) posted (#5) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-02-01 01:15:45 EST ---

REVIEW: https://review.gluster.org/16492 (glusterd: turn off client.io-threads for replicate volumes) posted (#6) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-02-01 09:56:52 EST ---

REVIEW: https://review.gluster.org/16502 (glusterd : do not load io-threads in client graph for replicate volumes) posted (#5) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2017-02-03 07:54:53 EST ---

COMMIT: https://review.gluster.org/16502 committed in master by Jeff Darcy (jdarcy) 
------
commit ff075a3d6f9b142911d25c27fd209838782bfff0
Author: Atin Mukherjee <amukherj>
Date:   Wed Feb 1 15:04:08 2017 +0530

    glusterd : do not load io-threads in client graph for replicate volumes
    
    client.io-threads has been turned on by default from release-3.9 onwards,
    however this has an adverse effects on replicate volumes due to the design
    limitations on replications, till that gets addressed through server side
    replication as a preventive measure it is wiser not to load io-threads in the
    client graph for replicate volumes.
    
    Change-Id: Ibc576d4517da23fcdf55c6f4d17b90152a8817d7
    BUG: 1418014
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: https://review.gluster.org/16502
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Prashanth Pai <ppai>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Jeff Darcy <jdarcy>