Spec URL: https://github.com/FZUG/repo/blob/master/rpms/deepin_project/deepin-shortcut-viewer.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mosquito/deepin/fedora-25-x86_64/00501609-deepin-shortcut-viewer/deepin-shortcut-viewer-1.0.2-1.git760b082.fc25.src.rpm
Description: deepin shortcut viewer
Fedora Account System Username: mosquito
+ package name is OK
+ license is acceptable for Fedora (GPLv3)
+ license is specified correctly
+ builds and installs OK
+ Requires/Provides/BuildRequires look OK
+ no scriptlets necessary
+ build flags are honoured
+ rpmlint shows nothing useful
- no docs and no license: there's a LICENSE file, and some documentation files, not sure if those are useful. Please add least add %license LICENSE.
CuteLogger is bundled. It is not packaged for Fedora, so according to the guidelines [https://fedoraproject.org/wiki/Bundled_Software_policy], a tag should be added:
If you know the version, also add "= <version>", but from a quick look at the sources, I don't see any version string there.
Thanks, i fixed it.
Look good now. Package is APPROVED. When uploading please do one more thing: update the %description to say a bit more more, like "This program is used to display ... by ... when ...".
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/deepin-shortcut-viewer