Bug 1419661

Description of problem:
Pcs accepts a resource agent name in the format "standard:provider:type" when "standard" is 'ocf', or "standard:type" otherwise. However we can get for example the name "systemd:lvm2-pvscan@252:2", see:

[vm-rhel72-1 ~] $ crm_resource --list-agents systemd|grep @
lvm2-pvscan@252:2

But the second colon in the name "systemd:lvm2-pvscan@252:2" does not separate a provider and a type. If such resource agent name is used in "pcs resource create" it produces an invalid cib.


How reproducible:
always


Steps to Reproduce:
[vm-rhel72-1 ~] $ pcs resource create X systemd:lvm2-pvscan@252:2

Actual results:
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
<cib


Expected results:
Success and
[vm-rhel72-1 ~] $ pcs cluster cib|grep 'primitive.*lvm2-pvscan' -A5
      <primitive class="systemd" id="X" type="lvm2-pvscan@252:2">
        <instance_attributes id="X-instance_attributes"/>
        <operations>
          <op id="X-monitor-interval-60s" interval="60s" name="monitor"/>
        </operations>
      </primitive>


Additional info:
In the current upstream version this bug is partially corrected and we get:
[vm-rhel72-1 ~] $ pcs resource create X systemd:lvm2-pvscan@252:2
Error: Invalid resource agent name 'systemd:lvm2-pvscan@252:2'. Use standard:provider:type when standard is 'ocf' or standard:type otherwise. List of standards and providers can be obtained by using commands 'pcs resource standards' and 'pcs resource providers'

Pcs validates the resource agent name and prevents to produce an invalid cib. But the behaviour is not correct. Moreover this validation is not correct and as a side effect it breaks the "pcs resource list" command.
[vm-rhel72-1 ~] $ pcs resource list systemd --nodesc
Traceback (most recent call last):
  File "/root/pcs/pcs/pcs", line 12, in <module>
    app.main(sys.argv[1:])
  File "/root/pcs/pcs/app.py", line 191, in main
    cmd_map[command](argv)
  File "/root/pcs/pcs/resource.py", line 49, in resource_cmd
    resource_list_available(lib, argv_next, modifiers)
  File "/root/pcs/pcs/resource.py", line 214, in resource_list_available
    agent_list = lib.resource_agent.list_agents(modifiers["describe"], search)
  File "/root/pcs/pcs/cli/common/lib_wrapper.py", line 96, in decorated_run
    return run_with_middleware(run, cli_env, *args, **kwargs)
  File "/root/pcs/pcs/cli/common/middleware.py", line 20, in run
    return next_in_line(env, *args, **kwargs)
  File "/root/pcs/pcs/cli/common/lib_wrapper.py", line 86, in run
    lib_call_result = run_library_command(lib_env, *args, **kwargs)
  File "/root/pcs/pcs/lib/commands/resource_agent.py", line 75, in list_agents
    resource_agent.ResourceAgent
  File "/root/pcs/pcs/lib/commands/resource_agent.py", line 93, in _complete_agent_list
    agent_metadata = metadata_class(runner, name)
  File "/root/pcs/pcs/lib/resource_agent.py", line 637, in __init__
    self._name_parts = self._prepare_name_parts(name)
  File "/root/pcs/pcs/lib/resource_agent.py", line 703, in _prepare_name_parts
    return get_resource_agent_name_from_string(name)
  File "/root/pcs/pcs/lib/resource_agent.py", line 111, in get_resource_agent_name_from_string
    raise InvalidResourceAgentName(full_agent_name)
pcs.lib.resource_agent.InvalidResourceAgentName