Bug 1420042 - RSpec 3 compatibility
Summary: RSpec 3 compatibility
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-rack-protection
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jun Aruga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-02-07 16:25 UTC by Jun Aruga
Modified: 2017-02-08 13:55 UTC (History)
2 users (show)

Fixed In Version: rubygem-rack-protection-1.5.3-4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-02-08 13:55:41 UTC
Type: Bug


Attachments (Terms of Use)
Patch for RSpec3 compatiblity (3.72 KB, patch)
2017-02-07 16:25 UTC, Jun Aruga
no flags Details | Diff

Description Jun Aruga 2017-02-07 16:25:07 UTC
Created attachment 1248455 [details]
Patch for RSpec3 compatiblity

Description of problem:

The package is using RSpec2 for tests.
However actually RSpec3 might be better.

So, I uploaded a patch for that.

Latest upstream rack-protection was being merged to sinatra as version 2 beta.
And it is using RSpec3 for tests.
But there is no good patch for our spec file.
So, I created a patch by myself as modification is simple.

Version-Release number of selected component (if applicable):
rubygem-rack-protection-1.5.3-3

I like it will be merged.

Comment 1 Jun Aruga 2017-02-07 16:27:49 UTC
I checked below things.

- License check: ok
- rpmlint check: ok
- Install check: ok

Comment 2 Vít Ondruch 2017-02-08 13:19:18 UTC
I noticed there is a typo in .spec file: s/proection/protection/

Otherwise the patch looks good. I approved your ACL, so feel free to apply the patch.

Comment 3 Jun Aruga 2017-02-08 13:55:41 UTC
Thanks!
I applied fixing the typo, and doing rebase.


Note You need to log in before you can comment on or make changes to this bug.