Hide Forgot
Created attachment 1248556 [details] the actual results Description of problem: 1.To live commit to non-enough space storage shows the block job has completed, but actually not. 2.QMP returns block_job_error during live commit, but finally it returns block_job_completed. Version-Release number of selected component (if applicable): qemu-kvm-rhev-2.8.0-1.el7.x86_64 3.10.0-546.rt56.453.el7.x86_64 How reproducible: 100% Steps to Reproduce: 1./usr/libexec/qemu-kvm -drive file=/home/image/rhel7.4.qcow2,format=qcow2,if=none,id=drive-virtio-disk0,werror=stop,rerror=stop -device virtio-blk-pci,drive=drive-virtio-disk0,id=virtio-disk0 -qmp tcp:localhost:4444,server -monitor stdio -net tap -net nic -smp 4 -m 2048 2.{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive-virtio-disk0", "snapshot-file": "/root/temp/sn1", "format": "qcow2" } } NOTE:/root/temp is mounted, whose total size is 1G. 3.{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive-virtio-disk0", "snapshot-file": "/root/sn2", "format": "qcow2" } } 4.dd if=/dev/urandom of=bigfile bs=1M count=2000 NOTE:run this command in guest 5.{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive-virtio-disk0", "snapshot-file": "/root/sn2", "format": "qcow2" } Actual results: QMP returns BLOCK_JOB_COMPLETED Expected results: QMP returns BLOCK_JOB_CANCELED Additional info: refer to the attachment for error details
Steps to Reproduce: 5.{ "execute": "block-commit", "arguments": { "device": "drive-virtio-disk0", "base": "/root/temp/sn1", "top": "/root/sn2", "speed": 1000000000 } NOTE: i made a mistake, the right command as above
Wait, "CANCELED" is only applicable to jobs that have been manually canceled, not jobs that encounter error. I went to reproduce and I indeed get the expected events: {u'timestamp': {u'seconds': 1494540938, u'microseconds': 740533}, u'data': {u'device': u'sda', u'action': u'report', u'operation': u'write'}, u'event': u'BLOCK_JOB_ERROR'} {u'timestamp': {u'seconds': 1494540938, u'microseconds': 742336}, u'data': {u'speed': 0, u'offset': 1994063872, u'len': 2391212032, u'error': u'No space left on device', u'device': u'sda', u'type': u'commit'}, u'event': u'BLOCK_JOB_COMPLETED'} If the COMPLETED event you received has the error field set, this is NOTABUG.
Yes, this is NOTABUG. Our test case expectation does not accurate, I will modify it.
Thank you! :)