RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

> Description of problem:

When resource-discovery option support has been added to 'constraint location add' and 'constraint location rule', the automatic CIB upgrade to version pacemaker-2.2+ has only been to the rule creation. The former command is missing this step therefore resulting in an invalid CIB.


> Version-Release number of selected component (if applicable):

pcs-0.9.152-10.el7
(upstream also affected)


> How reproducible:

Always


> Steps to Reproduce:
1. have a CIB with validate-with="pacemaker-2.1" or lower
2. pcs resource create MyDummy ocf:heartbeat:Dummy
3. pcs constraint location add MyLoc MyDummy <node> 100 resource-discovery=exclusive


> Actual results:

Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...


> Expected results:

Cluster CIB has been upgraded to latest version


> Additional info:

'location rule' code: https://github.com/ClusterLabs/pcs/blob/ba257076bf60ad7a624b645b306711f3525e6b1a/pcs/constraint.py#L729
'location add' code:  https://github.com/ClusterLabs/pcs/blob/ba257076bf60ad7a624b645b306711f3525e6b1a/pcs/constraint.py#L800

We will add CIB upgrade check to that function with respect to rsc-pattern as a part of bz1362493 patch. So we can fix this in the same time.

Created attachment 1321014 [details]
proposed fix

After Fix:

[vm-rhel72-1 ~] $ rpm -q pcs
pcs-0.9.160-1.el7.x86_64

[vm-rhel72-1 ~] $ cat cib-empty.xml
<cib epoch="557" num_updates="122" admin_epoch="0" validate-with="pacemaker-1.2" crm_feature_set="3.0.12" update-origin="rh7-3" update-client="crmd" cib-last-written="Thu Aug 23 16:49:17 2012" have-quorum="0" dc-uuid="2">
  <configuration>
    <crm_config/>
    <nodes>
    </nodes>
    <resources/>
    <constraints/>
  </configuration>
  <status/>
</cib>
[vm-rhel72-1 ~] $ pcs resource create MyDummy ocf:heartbeat:Dummy -f cib-empty.xml
[vm-rhel72-1 ~] $ pcs constraint location add MyLoc MyDummy vm-rhel72-1 100 resource-discovery=exclusive  -f cib-empty.xml
Cluster CIB has been upgraded to latest version
[vm-rhel72-1 ~] $ echo $?
0

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0866