Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1420571

Summary:	Massive xlator_t leak in graph-switch code
Product:	[Community] GlusterFS	Reporter:	Jeff Darcy <jdarcy>
Component:	core	Assignee:	Jeff Darcy <jdarcy>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.11.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1420810 (view as bug list)		Environment:
Last Closed:	2017-03-09 20:32:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1420810

Description Jeff Darcy 2017-02-09 00:55:10 UTC

In high-scale tests (hundreds of volumes with four bricks each) it became apparent that a frightening percentage of our memory in a brick process was being consumed by xlator_t structures, in numbers exactly proportional to the *square* of how many volumes we had.  This happens because every volume creation would result in a FETCHSPEC request being sent and acted upon for every previously existing volume.  Since the teardown of the graph used to process each such request wasn't freeing the xlator_t, this would leak every xlator_t in every temporary graph on every iteration.

The fix, quite simply, is to take advantage of the painstaking work already done and *actually free* the structure at the right point.

Comment 1 Worker Ant 2017-02-09 00:56:33 UTC

REVIEW: https://review.gluster.org/16570 (libglusterfs: fix serious leak of xlator_t structures) posted (#1) for review on master by Jeff Darcy (jdarcy)

Comment 2 Worker Ant 2017-02-09 13:49:13 UTC

COMMIT: https://review.gluster.org/16570 committed in master by Shyamsundar Ranganathan (srangana) 
------
commit 2199c688b73dfe90868f9469f92e21b0e0795e57
Author: Jeff Darcy <jdarcy>
Date:   Wed Feb 8 19:45:46 2017 -0500

    libglusterfs: fix serious leak of xlator_t structures
    
    There's a lot of logic (and some long comments) around how to free
    these structures safely, but then we didn't do it.  Now we do.
    
    Change-Id: I9731ae75c60e99cc43d33d0813a86912db97fd96
    BUG: 1420571
    Signed-off-by: Jeff Darcy <jdarcy>
    Reviewed-on: https://review.gluster.org/16570
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Poornima G <pgurusid>
    Reviewed-by: Shyamsundar Ranganathan <srangana>

Comment 3 Shyamsundar 2017-05-30 18:41:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.11.0, please open a new bug report.

glusterfs-3.11.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-May/000073.html
[2] https://www.gluster.org/pipermail/gluster-users/